Source: guile-3.0 Severity: normal Tags: patch User: debian-h...@lists.debian.org Usertags: hppa
Hi! The build of guile-3.0 on hppa currently fails with: continuations.c: In function 'scm_dynthrow': continuations.c:326:5: error: too few arguments to function 'grow_stack' 326 | grow_stack (cont); | ^~~~~~~~~~ continuations.c:276:1: note: declared here 276 | grow_stack (SCM cont, uint8_t *mra) | ^~~~~~~~~~ make[4]: *** [Makefile:2857: libguile_3.0_la-continuations.lo] Error 1 This is a regression in 3.0 and simply fixed by the attached patch which I have also sent upstream [2]. Please include it in the next upload. Thanks, Adrian > [1] > https://buildd.debian.org/status/fetch.php?pkg=guile-3.0&arch=hppa&ver=3.0.0%2B1-1&stamp=1580702308&raw=0 > [2] https://lists.gnu.org/archive/html/guile-devel/2020-02/msg00017.html -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
>From 9081d45472709b27f36a6b7f4be47e88f956a190 Mon Sep 17 00:00:00 2001 From: John Paul Adrian Glaubitz <glaub...@physik.fu-berlin.de> Date: Tue, 4 Feb 2020 12:12:24 +0100 Subject: [PATCH] Fix build of platforms where the stack grows upwards * libguile/continuations.c (scm_dynthrow): Fix missing mra parameter to grow_stack for SCM_STACK_GROWS_UP. --- libguile/continuations.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libguile/continuations.c b/libguile/continuations.c index 3f86c6bd4..67a47d38c 100644 --- a/libguile/continuations.c +++ b/libguile/continuations.c @@ -323,7 +323,7 @@ scm_dynthrow (SCM cont, uint8_t *mra) #if SCM_STACK_GROWS_UP if (dst + continuation->num_stack_items >= &stack_top_element) - grow_stack (cont); + grow_stack (cont, mra); #else dst -= continuation->num_stack_items; if (dst <= &stack_top_element) -- 2.25.0