Source: zita-resampler Version: 1.6.2-1 Tags: patch User: debian-cr...@lists.debian.org Usertags: ftcbfs
zita-resampler fails to cross build from source. This was already reported and supposedly fixed in #897049. However, the debian/rules portion of that patch went somehow missing. In addition to that, upstream introduce a new dependency. Building the apps directory now depends on an installation of the source directory in DESTDIR (notice the -I$(DESTDIR)/usr/include) flag. Therefore it must be built after installing the source directory. Failing to do that results in building again during make install - with the wrong compiler. Please consider applying the attached patch. Please also consider whether this DESTDIR hack in apps/Makefile is appropriate. The DESTDIR variable is not meant to influence the build at all and it turns out to have surprising effects here. It certainly fails the principle of least surprise. Helmut
diff --minimal -Nru zita-resampler-1.6.2/debian/changelog zita-resampler-1.6.2/debian/changelog --- zita-resampler-1.6.2/debian/changelog 2020-02-03 20:45:07.000000000 +0100 +++ zita-resampler-1.6.2/debian/changelog 2020-02-05 06:08:43.000000000 +0100 @@ -1,3 +1,12 @@ +zita-resampler (1.6.2-1.1) UNRELEASED; urgency=medium + + * Non-maintainer upload. + * Fix FTCBFS: (Closes: #-1) + + Let dh_auto_build pass cross tools to make. + + app/ build needs source/ install. + + -- Helmut Grohne <hel...@subdivi.de> Wed, 05 Feb 2020 06:08:43 +0100 + zita-resampler (1.6.2-1) unstable; urgency=medium * Team upload diff --minimal -Nru zita-resampler-1.6.2/debian/rules zita-resampler-1.6.2/debian/rules --- zita-resampler-1.6.2/debian/rules 2020-02-03 20:32:46.000000000 +0100 +++ zita-resampler-1.6.2/debian/rules 2020-02-05 06:08:43.000000000 +0100 @@ -19,8 +19,8 @@ override_dh_auto_install: dh_auto_install $(MAKE) -C source/ DESTDIR=$(DESTDIR) - $(MAKE) -C apps/ DESTDIR=$(DESTDIR) $(MAKE) -C source/ DESTDIR=$(DESTDIR) install + dh_auto_build -Dapps -- DESTDIR=$(DESTDIR) $(MAKE) -C apps/ DESTDIR=$(DESTDIR) install dh_install -plibzita-resampler-doc docs/* usr/share/doc/libzita-resampler-doc/docs/