Harald Dunkel writes ("Re: new network-manager-strongswan package"):
> https://afaics.de/git/network-manager-strongswan.git
> https://afaics.de/download/
Harald Dunkel writes ("Re: network-manager-strongswan FTBFS: error:
G_ADD_PRIVATE"):
> There is a new version 1.4.5-1 on salsa. Apparently it builds fine
> on Sid. Hopefully my sponsor finds a few minutes for a review.
Hi. For those reading the bug, I'm the sponsor Harald refers to.
I decided to reply here.
I looked at the diff etc. and I have some observations:
* It would be nice to add a Vcs-Git header.
* I noticed you changed the Build-Depends. There is a change to
debhelper, which is expected. But there are also changes to the
network-manager build-dependencies. I looked for some file in
upstream wqher etehse requirements are documented, and/or something
in the debian/changelog to explain or document the change, but
found nothing. Can you please explain ?
* Please can you consider providing an explanation of the patch
glib-private.patch *inside* that patch file. (Ideally patches
should be in git-format-patch format or or DEP-3 format.)
None of these observations look like blockers to me but I would like
to at least ask you for answers before I just upload it.
More on administrativia:
* Since you have already committed your finalised 1.4.5-1 version, it
would be best not to make more commits before bumping the changelog
version again. So, if in response to this review you would like to
make changes, rather than give explanations, please use 1.4.5-2 for
your next revision.
* In future, I am very happy to sponsor directly from git, especially
from salsa. I see we have pristine tar and everything. So just
push your branch (including pristine-tar) to salsa and email me.
There is no need for you to make a dsc and email me attachments.
In my review above I ignored your attachments and just worked with
the git branch (from your private server).
* Indeed, there is no need for you to make a signed tag. Because
salsa is access controlled I feel I can trust it enough for this, at
least as a baseline for review. If you like, feel free to leave the
changelog as UNRELEASED; I am happy to do that change to `unstable'
as part of the upload and push to salsa. If you would like to work
this way, please give user `iwj' access to the repo.
* If it's OK with you I like doing reviews in public. I think a "new
upstream version" bug against the package is a good place because it
means that if either of us drops it, our work is easily available as
a starting point for others.
Regards,
Ian.
--
Ian Jackson <[email protected]> These opinions are my own.
If I emailed you from an address @fyvzl.net or @evade.org.uk, that is
a private address which bypasses my fierce spamfilter.
