Package: release.debian.org
Severity: normal
Tags: buster
User: release.debian....@packages.debian.org
Usertags: pu
I'd like to fix an important bug in backuppc which prevents
`systemd reload backuppc.service` from failing. As a result of this bug
backuppc has to be restarted for systemd's supervision to be reset,
which interrupts ongoing jobs.
Source debdiff attached.
Thanks
-- System Information:
Debian Release: 10.3
APT prefers proposed-updates
APT policy: (990, 'proposed-updates'), (990, 'stable'), (500,
'stable-updates'), (500, 'oldstable-updates'), (500, 'unstable'), (500,
'oldstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.3.0-0.bpo.2-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8), LANGUAGE=en_GB:en
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru backuppc-3.3.2/debian/changelog backuppc-3.3.2/debian/changelog
--- backuppc-3.3.2/debian/changelog 2018-11-14 22:27:21.000000000 +0000
+++ backuppc-3.3.2/debian/changelog 2019-11-13 12:23:30.000000000 +0000
@@ -1,3 +1,11 @@
+backuppc (3.3.2-2+deb10u1) buster; urgency=medium
+
+ * 07-reload-user.patch: pass the username to start-stop-daemon when
+ reloading. This prevents reload failures and subsequent init system
+ games (Closes: #944611)
+
+ -- Jonathan Wiltshire <j...@debian.org> Wed, 13 Nov 2019 12:23:30 +0000
+
backuppc (3.3.2-2) unstable; urgency=low
* There are no logs to chown upon a first installation, so don't try to
diff -Nru backuppc-3.3.2/debian/init backuppc-3.3.2/debian/init
--- backuppc-3.3.2/debian/init 2018-11-14 21:40:11.000000000 +0000
+++ backuppc-3.3.2/debian/init 2019-11-13 12:23:30.000000000 +0000
@@ -81,7 +81,7 @@
;;
reload|force-reload)
log_begin_msg "Reloading $NAME configuration files..."
- start-stop-daemon --stop --pidfile /var/run/backuppc/BackupPC.pid \
+ start-stop-daemon --stop --pidfile /var/run/backuppc/BackupPC.pid -u $USER
\
--signal 1
log_end_msg $?
;;
diff -Nru backuppc-3.3.2/debian/patches/07-reload-user.patch
backuppc-3.3.2/debian/patches/07-reload-user.patch
--- backuppc-3.3.2/debian/patches/07-reload-user.patch 1970-01-01
01:00:00.000000000 +0100
+++ backuppc-3.3.2/debian/patches/07-reload-user.patch 2019-11-13
12:20:41.000000000 +0000
@@ -0,0 +1,18 @@
+Description: pass the username to start-stop-daemon when reloading
+Forwarded: no
+Bug-Debian: https://bugs.debian.org/944611
+Author: Jonathan Wiltshire <j...@tiger-computing.co.uk>
+
+Index: backuppc-3.3.2/init.d/src/debian-backuppc
+===================================================================
+--- backuppc-3.3.2.orig/init.d/src/debian-backuppc
++++ backuppc-3.3.2/init.d/src/debian-backuppc
+@@ -54,7 +54,7 @@ case "$1" in
+ ;;
+ reload|force-reload)
+ echo "Reloading $NAME configuration files"
+- start-stop-daemon --stop --pidfile $LOGDIR/BackupPC.pid \
++ start-stop-daemon --stop --pidfile $LOGDIR/BackupPC.pid -u $USER \
+ --signal 1 -x /usr/bin/perl
+ ;;
+ *)
diff -Nru backuppc-3.3.2/debian/patches/series
backuppc-3.3.2/debian/patches/series
--- backuppc-3.3.2/debian/patches/series 2018-11-14 21:40:11.000000000
+0000
+++ backuppc-3.3.2/debian/patches/series 2019-11-13 12:20:41.000000000
+0000
@@ -4,3 +4,4 @@
04-use-IT-Support-instead-of-IS.patch
05-fix-too-much-translation-and-charset.patch
06-fix-rrd-graph-permissions.patch
+07-reload-user.patch
