Package: patroni Hello,
please find my saved bug report (from reportbug) below. I was not able to figure out how to send it via sendmail in an reasonable amount of time. Best regards Alexander Willer Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 From: Alexander Willer <kont...@alexander-willer.de> To: Debian Bug Tracking System <sub...@bugs.debian.org> Subject: patroni: Missing quotes in pg_clonecluster_patroni script cause clone to fail Message-ID: <158391948662.28150.3593843939160182507.report...@ffdb-3ae75.aaa.lvn.ad.lvnbb.de> X-Mailer: reportbug 7.1.7 Date: Wed, 11 Mar 2020 10:38:06 +0100 X-Debbugs-Cc: kont...@alexander-willer.de UGFja2FnZTogcGF0cm9uaQpWZXJzaW9uOiAxLjYuNC0xLnBnZGcyMC4wNCsxClNldmVyaXR5OiBp bXBvcnRhbnQKCkRlYXIgTWFpbnRhaW5lciwKCndoZW4gcGF0cm9uaSB0cmllcyB0byBjbG9uZSBh IG5ldyBzZWNvbmRhcnkgc2VydmVyLCBpdCBmYWlscy4KClRoZSBlcnJvciBoYXBwZW5zIGluIHRo ZSBzY3JpcHQgL3Vzci9zaGFyZS9wYXRyb25pL3BnX2Nsb25lY2x1c3Rlcl9wYXRyb25pLiBJdCBz ZWVtcyB0byBoYXBwZW4gYmVjYXVzZSB0aGVyZSBhcmUgc29tZSBxdW90ZXMgbWlzc2luZyBmb3Ig dGhlICctLWRibmFtZT0nIGFyZ3VtZW50IHdoaWNoIGlzIHBhc3NlZCB0byBwZ19iYXNlYmFja3Vw LiBEdWUgdG8gdGhlIG1pc3NpbmcgcXVvdGVzLCB0aGUgY29ubnN0cmluZyBsb29rcyBsaWtlIG11 bHRpcGxlIGFyZ3VtZW50cyBpbnN0ZWFkIG9mIG9uZS4KCkFmdGVyIGFkZGluZyBxdW90ZXMgdG8g dGhlIHNjcmlwdCAobGluZSA0NCkgc28gdGhhdCB0aGUgbGFzdCBhcmd1bWVudCBsb29rcyBhcyBm b2xsb3dzLCB0aGUgY2xvbmUgcHJvY2VzcyB3b3JrcyBmbGF3bGVzc2x5OgoKLS1kYm5hbWU9IiRD T05OU1RSIgoKUGxlYXNlIGZpbmQgdGhlIGxvZyBvdXRwdXQgYmVsb3csIGJlZm9yZSB0aGUgZml4 IGFuZCB3aXRoIHRoZSAyLTV0aCBsaW5lIGJlaW5nIGN1c3RvbSBsb2cgb3V0cHV0IEkgYWRkZWQg dG8gc2VlIHRoZSBhcmd1bWVudHMgdGhlIHNjcmlwdCBpcyBjYWxsZWQgd2l0aDoKCk3DpHIgMTEg MTA6MTc6MTIgaG9zdDEyMyBwYXRyb25pWzUzMzldOiAyMDIwLTAzLTExIDEwOjE3OjEyLDg0MiBJ TkZPOiB0cnlpbmcgdG8gYm9vdHN0cmFwIGZyb20gbGVhZGVyICdob3N0MTIzJwpNw6RyIDExIDEw OjE3OjEyIGhvc3QxMjMgcGF0cm9uaVs1MzM5XTogLS1zY29wZT05LjYtdGVzdF9jbHVzdGVyCk3D pHIgMTEgMTA6MTc6MTIgaG9zdDEyMyBwYXRyb25pWzUzMzldOiAtLWRhdGFkaXI9L3Zhci9saWIv cG9zdGdyZXNxbC85LjYvdGVzdF9jbHVzdGVyCk3DpHIgMTEgMTA6MTc6MTIgaG9zdDEyMyBwYXRy b25pWzUzMzldOiAtLXJvbGU9cmVwbGljYQpNw6RyIDExIDEwOjE3OjEyIGhvc3QxMjMgcGF0cm9u aVs1MzM5XTogLS1jb25uc3RyaW5nPWRibmFtZT1wb3N0Z3JlcyB1c2VyPXJlcGxpY2F0b3IgaG9z dD0xMC4xMC43Ljk1IHBvcnQ9NTQzMgpNw6RyIDExIDEwOjE3OjEyIGhvc3QxMjMgcGF0cm9uaVs1 MzM5XTogd2FybmluZzogY29ycnVwdGVkIGNsdXN0ZXI6IGRhdGEgZGlyZWN0b3J5IGRvZXMgbm90 IGV4aXN0Ck3DpHIgMTEgMTA6MTc6MTIgaG9zdDEyMyBwYXRyb25pWzUzMzldOiBDcmVhdGluZyBu ZXcgY2x1c3RlciA5LjYvdGVzdF9jbHVzdGVyIC4uLgpNw6RyIDExIDEwOjE3OjEyIGhvc3QxMjMg cGF0cm9uaVs1MzM5XTogICBjb25maWcgL2V0Yy9wb3N0Z3Jlc3FsLzkuNi90ZXN0X2NsdXN0ZXIK TcOkciAxMSAxMDoxNzoxMiBob3N0MTIzIHBhdHJvbmlbNTMzOV06ICAgZGF0YSAgIC92YXIvbGli L3Bvc3RncmVzcWwvOS42L3Rlc3RfY2x1c3RlcgpNw6RyIDExIDEwOjE3OjEyIGhvc3QxMjMgcGF0 cm9uaVs1MzM5XTogICBsb2NhbGUgZGVfREUuVVRGLTgKTcOkciAxMSAxMDoxNzoxNCBob3N0MTIz IHBhdHJvbmlbNTMzOV06ICAgc29ja2V0IC92YXIvcnVuL3Bvc3RncmVzcWwKTcOkciAxMSAxMDox NzoxNCBob3N0MTIzIHBhdHJvbmlbNTMzOV06ICAgcG9ydCAgIDU0MzIKTcOkciAxMSAxMDoxNzox NCBob3N0MTIzIHBhdHJvbmlbNTMzOV06IHBnX2Jhc2ViYWNrdXA6IHp1IHZpZWxlIEtvbW1hbmRv emVpbGVuYXJndW1lbnRlIChkYXMgZXJzdGUgaXN0IMK7dXNlcj1yZXBsaWNhdG9ywqspCk3DpHIg MTEgMTA6MTc6MTQgaG9zdDEyMyBwYXRyb25pWzUzMzldOiBWZXJzdWNoZW4gU2llIMK7cGdfYmFz ZWJhY2t1cCAtLWhlbHDCqyBmw7xyIHdlaXRlcmUgSW5mb3JtYXRpb25lbi4KTcOkciAxMSAxMDox NzoxNCBob3N0MTIzIHBhdHJvbmlbNTMzOV06IDIwMjAtMDMtMTEgMTA6MTc6MTQsMTQ4IEVSUk9S OiBFcnJvciBjcmVhdGluZyByZXBsaWNhIHVzaW5nIG1ldGhvZCBwZ19jbG9uZWNsdXN0ZXI6IC91 c3Ivc2hhcmUvcGF0cm9uaS9wZ19jbG9uZWNsdXN0ZXJfcGF0cm9uaSBleGl0ZWQgd2l0aCBjb2Rl PTEKTcOkciAxMSAxMDoxNzoxNCBob3N0MTIzIHBhdHJvbmlbNTMzOV06IDIwMjAtMDMtMTEgMTA6 MTc6MTQsMTQ5IEVSUk9SOiBmYWlsZWQgdG8gYm9vdHN0cmFwIGZyb20gbGVhZGVyICdob3N0MTIz JwoKCi0tIFN5c3RlbSBJbmZvcm1hdGlvbjoKRGViaWFuIFJlbGVhc2U6IDkuMTIKICBBUFQgcHJl ZmVycyBvbGRzdGFibGUKICBBUFQgcG9saWN5OiAoNTAwLCAnb2xkc3RhYmxlJykKQXJjaGl0ZWN0 dXJlOiBhbWQ2NCAoeDg2XzY0KQoKS2VybmVsOiBMaW51eCA0LjkuMC0xMi1hbWQ2NCAoU01QIHcv NCBDUFUgY29yZXMpCkxvY2FsZTogTEFORz1kZV9ERS5VVEYtOCwgTENfQ1RZUEU9ZGVfREUuVVRG LTggKGNoYXJtYXA9VVRGLTgpLCBMQU5HVUFHRT1kZV9ERS5VVEYtOCAoY2hhcm1hcD1VVEYtOCkK U2hlbGw6IC9iaW4vc2ggbGlua2VkIHRvIC9iaW4vZGFzaApJbml0OiBzeXN0ZW1kICh2aWEgL3J1 bi9zeXN0ZW1kL3N5c3RlbSkKClZlcnNpb25zIG9mIHBhY2thZ2VzIHBhdHJvbmkgZGVwZW5kcyBv bjoKaWkgIGxzYi1iYXNlICAgICAgICAgICAgICAgOS4yMDE2MTEyNQppaSAgcHl0aG9uMyAgICAg ICAgICAgICAgICAzLjUuMy0xCmlpICBweXRob24zLWNkaWZmICAgICAgICAgIDEuMC0xfnBnZGc5 MCsxCmlpICBweXRob24zLWNsaWNrICAgICAgICAgIDYuNi0xCmlpICBweXRob24zLWNvbnN1bCAg ICAgICAgIDAuNy4xLTEKaWkgIHB5dGhvbjMtZGF0ZXV0aWwgICAgICAgMi41LjMtMgppaSAgcHl0 aG9uMy1ldGNkICAgICAgICAgICAwLjQuMy0yCmlpICBweXRob24zLXBrZy1yZXNvdXJjZXMgIDMz LjEuMS0xCmlpICBweXRob24zLXByZXR0eXRhYmxlICAgIDAuNy4yLTMKaWkgIHB5dGhvbjMtcHN1 dGlsICAgICAgICAgNS4wLjEtMQppaSAgcHl0aG9uMy1wc3ljb3BnMiAgICAgICAyLjYuMi0xCmlp ICBweXRob24zLXNpeCAgICAgICAgICAgIDEuMTAuMC0zCmlpICBweXRob24zLXR6bG9jYWwgICAg ICAgIDEuMy0xCmlpICBweXRob24zLXVybGxpYjMgICAgICAgIDEuMTkuMS0xCmlpICBweXRob24z LXlhbWwgICAgICAgICAgIDMuMTItMQoKVmVyc2lvbnMgb2YgcGFja2FnZXMgcGF0cm9uaSByZWNv bW1lbmRzOgppaSAgaXByb3V0ZTIgIDQuOS4wLTErZGViOXUxCgpWZXJzaW9ucyBvZiBwYWNrYWdl cyBwYXRyb25pIHN1Z2dlc3RzOgpwbiAgZXRjZC1zZXJ2ZXIgfCBjb25zdWwgfCB6b29rZWVwZXJk ICA8bm9uZT4KcG4gIGhhcHJveHkgICAgICAgICAgICAgICAgICAgICAgICAgICAgPG5vbmU+CnBu ICBwYXRyb25pLWRvYyAgICAgICAgICAgICAgICAgICAgICAgIDxub25lPgppaSAgcG9zdGdyZXNx bCAgICAgICAgICAgICAgICAgICAgICAgICA5LjYrMTgxK2RlYjl1MwpwbiAgdmlwLW1hbmFnZXIg ICAgICAgICAgICAgICAgICAgICAgICA8bm9uZT4KCi0tIG5vIGRlYmNvbmYgaW5mb3JtYXRpb24K ---- PLAINTEXT ---- Package: patroni Version: 1.6.4-1.pgdg20.04+1 Severity: important Dear Maintainer, when patroni tries to clone a new secondary server, it fails. The error happens in the script /usr/share/patroni/pg_clonecluster_patroni. It seems to happen because there are some quotes missing for the '--dbname=' argument which is passed to pg_basebackup. Due to the missing quotes, the connstring looks like multiple arguments instead of one. After adding quotes to the script (line 44) so that the last argument looks as follows, the clone process works flawlessly: --dbname="$CONNSTR" Please find the log output below, before the fix and with the 2-5th line being custom log output I added to see the arguments the script is called with: Mär 11 10:17:12 host123 patroni[5339]: 2020-03-11 10:17:12,842 INFO: trying to bootstrap from leader 'host123' Mär 11 10:17:12 host123 patroni[5339]: --scope=9.6-test_cluster Mär 11 10:17:12 host123 patroni[5339]: --datadir=/var/lib/postgresql/9.6/test_cluster Mär 11 10:17:12 host123 patroni[5339]: --role=replica Mär 11 10:17:12 host123 patroni[5339]: --connstring=dbname=postgres user=replicator host=10.10.7.95 port=5432 Mär 11 10:17:12 host123 patroni[5339]: warning: corrupted cluster: data directory does not exist Mär 11 10:17:12 host123 patroni[5339]: Creating new cluster 9.6/test_cluster ... Mär 11 10:17:12 host123 patroni[5339]: config /etc/postgresql/9.6/test_cluster Mär 11 10:17:12 host123 patroni[5339]: data /var/lib/postgresql/9.6/test_cluster Mär 11 10:17:12 host123 patroni[5339]: locale de_DE.UTF-8 Mär 11 10:17:14 host123 patroni[5339]: socket /var/run/postgresql Mär 11 10:17:14 host123 patroni[5339]: port 5432 Mär 11 10:17:14 host123 patroni[5339]: pg_basebackup: zu viele Kommandozeilenargumente (das erste ist »user=replicator«) Mär 11 10:17:14 host123 patroni[5339]: Versuchen Sie »pg_basebackup --help« für weitere Informationen. Mär 11 10:17:14 host123 patroni[5339]: 2020-03-11 10:17:14,148 ERROR: Error creating replica using method pg_clonecluster: /usr/share/patroni/pg_clonecluster_patroni exited with code=1 Mär 11 10:17:14 host123 patroni[5339]: 2020-03-11 10:17:14,149 ERROR: failed to bootstrap from leader 'host123' -- System Information: Debian Release: 9.12 APT prefers oldstable APT policy: (500, 'oldstable') Architecture: amd64 (x86_64) Kernel: Linux 4.9.0-12-amd64 (SMP w/4 CPU cores) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages patroni depends on: ii lsb-base 9.20161125 ii python3 3.5.3-1 ii python3-cdiff 1.0-1~pgdg90+1 ii python3-click 6.6-1 ii python3-consul 0.7.1-1 ii python3-dateutil 2.5.3-2 ii python3-etcd 0.4.3-2 ii python3-pkg-resources 33.1.1-1 ii python3-prettytable 0.7.2-3 ii python3-psutil 5.0.1-1 ii python3-psycopg2 2.6.2-1 ii python3-six 1.10.0-3 ii python3-tzlocal 1.3-1 ii python3-urllib3 1.19.1-1 ii python3-yaml 3.12-1 Versions of packages patroni recommends: ii iproute2 4.9.0-1+deb9u1 Versions of packages patroni suggests: pn etcd-server | consul | zookeeperd <none> pn haproxy <none> pn patroni-doc <none> ii postgresql 9.6+181+deb9u3 pn vip-manager <none> -- no debconf information
