On Sat, 14 Mar 2020 09:23:49 +0100 intrig...@debian.org wrote:
> Package: python3-stem
> Version: 1.7.1-1.1
> Severity: serious
>
> Hi,
>
> onioncircuits fails to start on current sid:
>
> Traceback (most recent call last):
> File "/bin/onioncircuits", line 657, in <module>
> app = OnionCircuitsApplication()
> File "/bin/onioncircuits", line 633, in __init__
> self.connect_controller()
> File "/bin/onioncircuits", line 647, in connect_controller
> self.controller = stem.connection.connect(**connect_args)
> File "/usr/lib/python3/dist-packages/stem/connection.py", line 291, in
connect
> return _connect_auth(control_connection, password, password_prompt,
chroot_path, controller)
> File "/usr/lib/python3/dist-packages/stem/connection.py", line 375, in
_connect_auth
> return controller(control_socket, is_authenticated = True)
> File "/usr/lib/python3/dist-packages/stem/control.py", line 1057, in
__init__
> super(Controller, self).__init__(control_socket, is_authenticated)
> File "/usr/lib/python3/dist-packages/stem/control.py", line 585, in
__init__
> self._post_authentication()
> File "/usr/lib/python3/dist-packages/stem/control.py", line 3902, in
_post_authentication
> owning_pid = self.get_conf('__OwningControllerProcess', None)
> File "/usr/lib/python3/dist-packages/stem/control.py", line 2170, in
get_conf
> entries = self.get_conf_map(param, default, multiple)
> File "/usr/lib/python3/dist-packages/stem/control.py", line 2273, in
get_conf_map
> for key in reply:
> RuntimeError: dictionary keys changed during iteration
>
>
> onionshare-gui fails to start with the same error since I upgraded to
> python 3.8.
>
> I think that's https://trac.torproject.org/projects/tor/ticket/30882,
> which was fixed upstream with this commit:
> https://gitweb.torproject.org/stem.git/commit/stem/control.py?
id=b5aecb743d33db1a6378d59792d8e57305b6c6f2
>
> I confirm that this commit fixes the problem I'm experiencing with
> onioncircuits and onionshare.
>
> Until you, or someone else, finds time to package the 1.8.0 upstream
> release, could you please import that fix as a Debian patch?
> Alternatively, would you mind if someone else did that as an NMU?I'm going to NMU this since it's one of the python3.8 transition blockers. NMU diff attached. Scott K
diff -Nru python-stem-1.7.1/debian/changelog python-stem-1.7.1/debian/changelog --- python-stem-1.7.1/debian/changelog 2019-10-05 21:50:32.000000000 -0400 +++ python-stem-1.7.1/debian/changelog 2020-03-24 16:47:02.000000000 -0400 @@ -1,3 +1,10 @@ +python-stem (1.7.1-1.2) unstable; urgency=medium + + * Non-maintainer upload. + * Add fix from upstream to fix dictionary key error (Closes: #953863 + + -- Scott Kitterman <sc...@kitterman.com> Tue, 24 Mar 2020 16:47:02 -0400 + python-stem (1.7.1-1.1) unstable; urgency=medium * Non-maintainer upload. diff -Nru python-stem-1.7.1/debian/patches/key_order.patch python-stem-1.7.1/debian/patches/key_order.patch --- python-stem-1.7.1/debian/patches/key_order.patch 1969-12-31 19:00:00.000000000 -0500 +++ python-stem-1.7.1/debian/patches/key_order.patch 2020-03-24 16:47:02.000000000 -0400 @@ -0,0 +1,18 @@ +Description: Fix from upstream to fix dictionary key error +Author: Scott Kitterman <sc...@kitterman.com> +Bug-Debian: https://bugs.debian.org/953863 +Origin: https://gitweb.torproject.org/stem.git/commit/?id=b5aecb7 +Forwarded: not-needed +Last-Update: 2020-03-24 + +--- python-stem-1.7.1.orig/stem/control.py ++++ python-stem-1.7.1/stem/control.py +@@ -2270,7 +2270,7 @@ class Controller(BaseController): + # entries since the user didn't request those by their key, so we can't + # be sure what they wanted. + +- for key in reply: ++ for key in list(reply): + if not key.lower() in MAPPED_CONFIG_KEYS.values(): + user_expected_key = _case_insensitive_lookup(params, key, key) + diff -Nru python-stem-1.7.1/debian/patches/series python-stem-1.7.1/debian/patches/series --- python-stem-1.7.1/debian/patches/series 1969-12-31 19:00:00.000000000 -0500 +++ python-stem-1.7.1/debian/patches/series 2020-03-24 16:47:02.000000000 -0400 @@ -0,0 +1 @@ +key_order.patch
signature.asc
Description: This is a digitally signed message part.
