Package: jemalloc
Version: 5.2.1-1
Severity: minor
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu focal ubuntu-patch
Hi Faidon,
In Ubuntu, we are in the process of moving the i386 architecture to a
compatibility-only layer on amd64, and therefore we are also moving our
autopkgtest infrastructure to test i386 binaries in a cross-environment.
This requires changes to some tests so that they are cross-aware and can do
the right thing.
The jemalloc tests currently fail in this environment, because they include
build tests that do not invoke the toolchain in a cross-aware manner, and do
not declare their test dependencies in a cross-friendly matter. I've
verified that the attached patch lets the tests successfully build (and run)
i386 tests on an amd64 host.
Note that upstream autopkgtest doesn't currently set DEB_HOST_ARCH so this
is a complete no-op in Debian for the moment. Support for cross-testing in
autopkgtest is currently awaiting review at
https://salsa.debian.org/ci-team/autopkgtest/merge_requests/69 and once
landed, will still have no effect unless autopkgtest is invoked with a '-a'
option. So this change should be safe to land in your package despite this
not being upstream in autopkgtest.
Thanks for considering,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru jemalloc-5.2.1/debian/tests/01.compile-and-run-test-program.t
jemalloc-5.2.1/debian/tests/01.compile-and-run-test-program.t
--- jemalloc-5.2.1/debian/tests/01.compile-and-run-test-program.t
2019-01-07 18:37:43.000000000 -0800
+++ jemalloc-5.2.1/debian/tests/01.compile-and-run-test-program.t
2020-04-02 00:05:25.000000000 -0700
@@ -4,8 +4,14 @@
. /usr/share/sharness/sharness.sh
+if [ -n "${DEB_HOST_GNU_TYPE:-}" ]; then
+ CROSS_COMPILE="$DEB_HOST_GNU_TYPE-"
+else
+ CROSS_COMPILE=
+fi
+
test_expect_success "compile test program against libjemalloc" "
- gcc ../ex_stats_print.c -o ex_stats_print -ljemalloc
+ ${CROSS_COMPILE}gcc ../ex_stats_print.c -o ex_stats_print -ljemalloc
"
test_expect_success "run test program" "
./ex_stats_print
diff -Nru jemalloc-5.2.1/debian/tests/control
jemalloc-5.2.1/debian/tests/control
--- jemalloc-5.2.1/debian/tests/control 2019-01-07 18:37:43.000000000 -0800
+++ jemalloc-5.2.1/debian/tests/control 2020-04-02 00:06:07.000000000 -0700
@@ -1,2 +1,2 @@
Tests: run-tests
-Depends: @,gcc,perl,libc6-dev,sharness
+Depends: @, build-essential, perl:native, sharness:native
