On Fri, 30 Aug 2019 07:36:15 +0000 Matthias Klose <d...@debian.org> wrote: > Package: src:python-apt > Version: 1.8.4 > Severity: normal > Tags: sid bullseye > User: debian-pyt...@lists.debian.org > Usertags: py2removal
Hey Julian, as part of this effort, could you start by switching to pyflakes3? the changes should be: ``` diff --git a/debian/control b/debian/control index 6098a6e7..e5b8bffd 100644 --- a/debian/control +++ b/debian/control @@ -25,7 +25,7 @@ Build-Depends: apt (>= 1.0.9.4), gnupg, dirmngr | gnupg (<< 2), pycodestyle, - pyflakes + pyflakes3, Vcs-Git: https://salsa.debian.org/apt-team/python-apt.git Vcs-Browser: https://salsa.debian.org/apt-team/python-apt diff --git a/tests/test_pyflakes.py b/tests/test_pyflakes.py index 4dbaa404..8341ecd4 100644 --- a/tests/test_pyflakes.py +++ b/tests/test_pyflakes.py @@ -31,7 +31,7 @@ class TestPyflakesClean(testcommon.TestCase): return files def test_pyflakes_clean(self): - cmd = ["pyflakes"] + self.get_py_files(self.TOPLEVEL) + cmd = ["pyflakes3"] + self.get_py_files(self.TOPLEVEL) res = subprocess.call(cmd) if res != 0: self.fail("pyflakes failed with: %s" % res) ``` and i guess you may want to skip test_pyflakes.py as it fails with: /build/python-apt-2.0.0/tests/test_hashes.py:93: undefined name 'unicode' /build/python-apt-2.0.0/tests/test_hashes.py:94: undefined name 'unicode' /build/python-apt-2.0.0/tests/test_hashes.py:95: undefined name 'unicode' /build/python-apt-2.0.0/tests/test_hashes.py:96: undefined name 'unicode' /build/python-apt-2.0.0/apt/progress/text.py:45: undefined name 'raw_input' F...................... or update the code, but that may be incompatible with py2 this will help free up pyflakes for removal Regards, Sandro