Package: plymouth
Version: 0.9.4-2
Severity: normal

Dear Maintainer,

Default plymouth theme with name "futureprototype" is used.
I am using 2 different monitors with size 1280 x 1024 and 1280 x 800.
Message like "resuming from hibernation" is written in the middle of the text
"Debian" with the same color (white)
and therefore the message is unreadable. Same problem with progress-percentage
during a software-upgrade.

Problem is at /usr/share/plymouth/themes/futureprototype/futureprototype.script
at routine TextYOffset.
This routine checks if the message, including some reserved lines, fits at the
screen.
If not, then the message is shifted upwards until it fits.
Coding:
    if (y + text_height > min_height)
        y = min_height - text_height;

This is wrong, because y is the vertical offset of the message at the largest
screen
 and min_height is the height of the smallest screen.
This causes a shift of the text, although it fits at the smallest screen.
Also the shift is not correct, because it computes the vertical offset y
from the top of the smallest screen in stead of the largest screen.
Corrected code:
    if (y - Window.GetY() + text_height > min_height)
    # shift to top of smallest window
        y = Window.GetY() + 1;

The message is shifted now to the first line that is visble on both screens,
to avoid overlapping the "Debian"-text.

With the corrected test the message is not shifted anymore at the used
monitors.

This wrong code is also present at some other older plymouth scripts and also
at ubuntu,
but does not harm there.
~



-- System Information:
Debian Release: bullseye/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 5.4.0-4-686-pae (SMP w/2 CPU cores)
Kernel taint flags: TAINT_DIE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages plymouth depends on:
ii  init-system-helpers  1.57
ii  initramfs-tools      0.136
ii  libc6                2.30-4
ii  libdrm2              2.4.100-4
ii  libplymouth4         0.9.4-2
ii  lsb-base             11.1.0
ii  systemd              244.3-1
ii  udev                 244.3-1

plymouth recommends no packages.

Versions of packages plymouth suggests:
ii  desktop-base     10.0.3
pn  plymouth-themes  <none>

-- Configuration Files:
/etc/plymouth/plymouthd.conf changed:
[Daemon]
Theme=futureprototype


-- no debconf information

Reply via email to