Hi Guillem,

On Mon, Apr 20, 2020 at 12:13:30AM +0200, Guillem Jover wrote:
> Hi!
> 
> On Mon, 2020-04-06 at 14:57:30 -0400, Taowa wrote:
> > Package: dpkg
> > Version: 1.19.7
> > Tags: patch
> 
> > --require-valid-signature currently uses the DD uploading and DM
> > keyrings (among others), it should also check against the DD
> > nonuploading keyring as they are treated like DMs as per [1,2].
> 
> Thanks for the patch! The change to the .pot should have gone instead
> to the man/dpkg-source.man (but that didn't trigger a git grep I guess
> due to the escaped «-» :/, I'll be moving to POD so that this kind of
> thing does not happen among other stuff :), I've fixed this locally.

Great, thanks :)
 
> I was wondering though how do you want it to be attributed when I
> commit to git? Say:
> 
>   Taowa Munene-Tardif <ta...@debian.org>
> 
> or like in the From to the bug report?
> 
>   Taowa <ta...@taowa.ca>
> 
> Something else? :)

Taowa Munene-Tardif <ta...@debian.org> is my preference, but I hadn't
gotten around to sending email as taowa@d.o yet. Thanks for asking!
 
> (I'd recommend setting up git config user.email, committing patches to
> git and then using «git format-patch» so that you state clearly this
> kind of thing. :)
 
That seems like a much easier workflow, I'll keep it in mind for next
time.

Thanks again,
Taowa

-- 
Taowa Munene-Tardif
ta...@debian.org
taowa.ca
Montréal

Reply via email to