Control: tags -1 +moreinfo Hi Seunghun,
Thanks for working on libtpms packaging in Debian and taking over maintenance. I sponsored the previous upload at https://ftp-master.debian.org/new/libtpms_0.7.0-1.html . After looking into your packaging, I think there are some issues as listed below. Please consider solving them and remove the "moreinfo" tag afterwards. * This one is critical: With new package, *NEVER* override dh_usrlocal in debian/rules file. Debian package should not ship files under /usr/local/. If there are special reasons about handling /usr/local/, I'd be happy to know it. * Please consider using "include /usr/share/dpkg/architecture.mk" instead of manual invocation of dpkg-architecture to get the value of DEB_HOST_MULTIARCH variable in debian/rules file. * The "--with autoreconf" parameter is useless now since it is the default for debhelper compatibility level 12. * Please strip all old changelogs entries from debian/changelog; those old parts are not part of Debian. * This one is also critical: Please do not list ${misc:Pre-Depends} in the Depends: field of libtpms0. Normally this variable substitution is not needed now; if you really needed, please use "Pre-Depends: ${misc:Pre-Depends}" instead. * With your current debian/*.install files, there are absolutely no necessity to build-depends on dh-exec. Please remove such dependency and remove corresponding shebang in *.install files. Let me know after you finish all those tweaks or if you have any questions. -- Regards, Boyuan Yang 在 2020-04-21星期二的 07:55 +0900,Seunghun Han写道: > Package: sponsorship-requests > Severity: wishlist > > Dear mentors, > > I am looking for a sponsor for my package "libtpms" > > * Package name : libtpms > Version : 0.8.0~dev1-1 > Upstream Author : Stefan Berger <stef...@linux.vnet.ibm.com> > * URL : https://github.com/stefanberger/libtpms > * License : BSD-3-clause > * Vcs : https://salsa.debian.org/kkamagui-guest/libtpms > Section : libs > > It builds those binary packages: > > libtpms0 - TPM emulation library > libtpms-dev - libtpms header files and man pages > > To access further information about this package, please visit the > following URL: > > https://mentors.debian.net/package/libtpms > > Alternatively, one can download the package with dget using this command: > > dget -x > https://mentors.debian.net/debian/pool/main/libt/libtpms/libtpms_0.8.0~dev1-1.dsc > > Changes since the last upload: > > * New maintainer (Closes: #958071) > * Updated standards version to 4.5.0 in debian/control > * Updated debhelper version to 12 in debian/control > * Added Rules-Requires-Root to debian/control > * Added Vcs-Browser and Vcs-Git to debian/control > * Removed autotools-dev and dh-autoreconf from debian/control > * Removed autotools-dev and parallel option from debian/rules > * Converted debian/copyright to dep5-copyright format > * Added debian/watch file > * Added debian/libtpms.symbols file > * Added debian/upstream/metadata file > * Changed section of man pages from 1 to 3 > * Fixed typos and a long line warning in man pages > * Set date of man pages to last changelog entry > > Regards, > > -- > Seunghun Han >
signature.asc
Description: This is a digitally signed message part