Package: vim-editorconfig
Version: 0.3.3+dfsg-2
Severity: normal

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

I see in #851572 the dependency was added on vim-nox, but it appears to me
that this was done out of an abundance of caution. Caution is good, but I
mean to point out that the reporter wasn't having any difficulties:
> https://github.com/editorconfig/editorconfig-vim#installation states
> that vim needs to have enabled python support. This support is included
> in the "vim-nox" package so it might make sense to add a dependency to
> that package instead of the "vim" package.

That's not true: Python isn't necessary, and if it were all versions of Vim
except for vim-tiny have support for it. The README says
> If your Vim is not compiled with +python feature (...), please first
> download the EditorConfig core

> This plugin would NOT work if neither +python nor EditorConfig core is
> available.

(It didn't get mentioned in the README until a couple years after [1], but
Python 2 or Python 3 are sufficient.) Since vim-editorconfig does depend on
editorconfig, Python support in Vim isn't needed.

In fact editorconfig.txt says there is a third option by which you can get
away with neither, by invoking the Python interpreter outside Vim:
> Specify the mode of EditorConfig core. Generally it is OK to leave this option
> empty. There are 3 modes currently: "external_command", "python_builtin",
> "python_external".
> 
>     python_builtin:     Use the vim built-in python to run the python version
>                         EditorConfig Core.
>     python_external:    Use an external python interpreter to run the python
>                         version EditorConfig Core.
>     external_command:   Run external EditorConfig Core.

However all of the search paths for an external Python interpreter still look
for Python 2, so I don't think that works without patching.

debian/copyright has
> Files-Excluded: plugin/editorconfig-core-py
but vim-editorconfig doesn't depend/recommend/suggest python3-editorconfig
in its place. Because vim-editorconfig isn't patched to search outside of
its runtime path in /usr/lib/python3/dist-packages/editorconfig I don't think
it would find them or run any Python code for that matter.

I don't think the release candidate upstream uses Python at all anymore, so
please take that invitation to drop the need for Python when it comes.

[1] 
https://github.com/editorconfig/editorconfig-vim/pull/52#issuecomment-406514109

- -- System Information:
Debian Release: bullseye/sid
  APT prefers testing
  APT policy: (500, 'testing'), (2, 'unstable'), (1, 'testing-debug'), (1, 
'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.5.0-1-amd64 (SMP w/2 CPU cores)
Kernel taint flags: TAINT_WARN, TAINT_FIRMWARE_WORKAROUND
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE= 
(charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages vim-editorconfig depends on:
ii  editorconfig  0.12.1-1.1
ii  vim-nox       2:8.2.0439-1

Versions of packages vim-editorconfig recommends:
ii  vim-addon-manager  0.5.10

vim-editorconfig suggests no packages.

- -- no debconf information

-----BEGIN PGP SIGNATURE-----

iHUEARYIAB0WIQT287WtmxUhmhucNnhyvHFIwKstpwUCXqSMbgAKCRByvHFIwKst
p3hDAP9cYT0e5fADRboC8l+x0VHUJXEWzCxQHsFMoDEt8YFW/wEA5HisEhHgRWzC
YVTGGP/gD8xA7SLIJfP3EYU6YJx3IQQ=
=P4Q6
-----END PGP SIGNATURE-----

Reply via email to