Package: acpi-call-dkms
Version: 1.1.0-5
Hi Raphael,
make.log says:
----------------------------------------------------------------------
DKMS make.log for acpi-call-1.1.0 for kernel 5.6.0-1-amd64 (x86_64)
Mo 4. Mai 17:42:51 CEST 2020
make: Entering directory '/usr/src/linux-headers-5.6.0-1-amd64'
AR /var/lib/dkms/acpi-call/1.1.0/build/built-in.a
CC [M] /var/lib/dkms/acpi-call/1.1.0/build/acpi_call.o
/var/lib/dkms/acpi-call/1.1.0/build/acpi_call.c: In function
‘init_acpi_call’:
/var/lib/dkms/acpi-call/1.1.0/build/acpi_call.c:356:53: error: passing
argument 4 of ‘proc_create’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
356 |
&proc_acpi_operations);
|
^~~~~~~~~~~~~~~~~~~~~
| |
| struct
file_operations *
In file included from /var/lib/dkms/acpi-call/1.1.0/build/acpi_call.c:6:
/usr/src/linux-headers-5.6.0-1-common/include/linux/proc_fs.h:64:24:
note: expected ‘const struct proc_ops *’ but argument is of type ‘struct
file_operations *’
64 | struct proc_dir_entry *proc_create(const char *name, umode_t
mode, struct proc_dir_entry *parent, const struct proc_ops *proc_ops);
| ^~~~~~~~~~~
cc1: some warnings being treated as errors
make[2]: ***
[/usr/src/linux-headers-5.6.0-1-common/scripts/Makefile.build:273:
/var/lib/dkms/acpi-call/1.1.0/build/acpi_call.o] Error 1
make[1]: *** [/usr/src/linux-headers-5.6.0-1-common/Makefile:1696:
/var/lib/dkms/acpi-call/1.1.0/build] Error 2
make: *** [/usr/src/linux-headers-5.6.0-1-common/Makefile:180: sub-make]
Error 2
make: Leaving directory '/usr/src/linux-headers-5.6.0-1-amd64'
----------------------------------------------------------------------
Patch is attached. For good measure it is also backwards compatible with
kernels < 5.6.
--
Freundliche Grüße / Kind regards,
Thomas Koch
--- acpi_call.c-orig 2020-05-04 13:25:32.691890015 +0200
+++ acpi_call.c 2020-05-04 13:30:48.732403548 +0200
@@ -317,11 +317,18 @@
return ret;
}
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 6, 0)
+static struct proc_ops proc_acpi_operations = {
+ .proc_read = acpi_proc_read,
+ .proc_write = acpi_proc_write,
+};
+#else
static struct file_operations proc_acpi_operations = {
.owner = THIS_MODULE,
.read = acpi_proc_read,
.write = acpi_proc_write,
};
+#endif
#else
static int acpi_proc_read(char *page, char **start, off_t off,
DKMS make.log for acpi-call-1.1.0 for kernel 5.6.0-1-amd64 (x86_64)
Mo 4. Mai 17:42:51 CEST 2020
make: Entering directory '/usr/src/linux-headers-5.6.0-1-amd64'
AR /var/lib/dkms/acpi-call/1.1.0/build/built-in.a
CC [M] /var/lib/dkms/acpi-call/1.1.0/build/acpi_call.o
/var/lib/dkms/acpi-call/1.1.0/build/acpi_call.c: In function ‘init_acpi_call’:
/var/lib/dkms/acpi-call/1.1.0/build/acpi_call.c:356:53: error: passing argument 4 of ‘proc_create’ from incompatible pointer type [-Werror=incompatible-pointer-types]
356 | &proc_acpi_operations);
| ^~~~~~~~~~~~~~~~~~~~~
| |
| struct file_operations *
In file included from /var/lib/dkms/acpi-call/1.1.0/build/acpi_call.c:6:
/usr/src/linux-headers-5.6.0-1-common/include/linux/proc_fs.h:64:24: note: expected ‘const struct proc_ops *’ but argument is of type ‘struct file_operations *’
64 | struct proc_dir_entry *proc_create(const char *name, umode_t mode, struct proc_dir_entry *parent, const struct proc_ops *proc_ops);
| ^~~~~~~~~~~
cc1: some warnings being treated as errors
make[2]: *** [/usr/src/linux-headers-5.6.0-1-common/scripts/Makefile.build:273: /var/lib/dkms/acpi-call/1.1.0/build/acpi_call.o] Error 1
make[1]: *** [/usr/src/linux-headers-5.6.0-1-common/Makefile:1696: /var/lib/dkms/acpi-call/1.1.0/build] Error 2
make: *** [/usr/src/linux-headers-5.6.0-1-common/Makefile:180: sub-make] Error 2
make: Leaving directory '/usr/src/linux-headers-5.6.0-1-amd64'
