Hi! On Xuñ 02 2020, Gianluigi Tiesi wrote: > Looks like bridge-utils already does it in: > /lib/bridge-utils/ifupdown.sh > > # Activate VLAN filtering on VLAN aware bridges > > if [ "$IF_BRIDGE_VLAN_AWARE" = "yes" ]; then > ip link set dev $IFACE type bridge vlan_filtering 1 > > else > ip link set dev $IFACE type bridge vlan_filtering 0 > > fi > > > the problem is I get operation not supported when setting vlan_filtering 0 > on my bridge, does the else really make sense here?
Well, this was added due to bugs.debian.org/950879 reported by Benedikt who kindly supplied the patch, the patch didn't cause any trouble on the tests I did and that's why I applied it like he sent it. I have added Benedikt to my reply for him to comment on this. As I understand it, Gianluigi, if we remove the else there we won't set vlan filtering to 0 and thus you won't get the error, right? We have two options here, one is to remove it and the other to send the possible errors on the setting to 0 case to /dev/null. As I see it, maybe the second option is better, as if one has set this to yes and then sets it to no without rebooting, he wouldn't get the expected behaviour. Benedikt and Gianluigi, what do you think? Regards. -- Manty/BestiaTester -> http://manty.net
