Bug#954872: buildd.debian.org: Legends for the graphs on https://buildd.debian.org/stats/ half-gone

[Manuel A. Fernandez Montecelo]

Hi,

2020-03-24 19:04 Aurelien Jarno:

On 2020-03-24 18:47, nabijaczleweli wrote:

Package: buildd.debian.org
Severity: normal

Hello,

The legends for the graphs on https://buildd.debian.org/stats/ seem to
be partway gone, mostly affecting the colour and start of the
architecture name.

See the attached graph.png, taken from the site as I write this.

This is a know issue, due to a change in the R packages in Debian
Buster. If someone has good knowledge of R, patches are welcome.

I tried to create a merge request in salsa but could not, for some reason.

I attach a patch that fixes this, at least when downloading the data and
generating the files locally with recent versions of the packages from
unstable.

But if not, it's easy to see how to further tweak the values, based on
the patch.

Hope that helps.


Cheers.
--
Manuel A. Fernandez Montecelo <manuel.montez...@gmail.com>


diff -ur a/graph-ports.R b/graph-ports.R
--- a/graph-ports.R	2020-07-01 01:01:59.514162160 +0200
+++ b/graph-ports.R	2020-07-01 01:02:18.706266654 +0200
@@ -19,7 +19,7 @@
 
 plotwb <- function (file,title,p,linept=85,height=7.5,width=10,pch=1:18) {
 	bitmap(file=file,type="png16m",width=width,height=height,res=64)
-	layout(matrix(c(1,1,2,2),2,2),widths=c(0.85,0.15))
+	layout(matrix(c(1,1,2,2),2,2),widths=c(0.80,0.20))
 	par(mar=c(5,4,4,2)+0.1) 
 	par(lab=c(10,10,7))
 	plot(p,type="o",plot.type="single",col=1:18,pch=pch,xlab="date",
@@ -29,7 +29,7 @@
 	axis(4)
 	plot.new()
 	par(plt=c(0,1,0,1))        
-	legend(-1.2,1, arch, col=1:18, pch=pch, lwd=2, bg='gray90', cex=1.5)  
+	legend('topright', arch, col=1:18, pch=pch, lwd=2, bg='gray90', cex=1.5)  
 }
 v <- readdata("/srv/wanna-build/etc/graph-ports-data",1)
 plotwb("/srv/buildd.debian.org/web/stats/graph-ports.png","What percent is built for each architecture",v,85,7.5,10,".")
diff -ur a/graph.R b/graph.R
--- a/graph.R	2020-07-01 01:01:38.710048877 +0200
+++ b/graph.R	2020-07-01 01:03:00.938496574 +0200
@@ -35,7 +35,7 @@
 
 plotwb <- function (file,title,p,linept=85,height=7.5,width=10,pch=1:18) {
 	bitmap(file=file,type="png16m",width=width,height=height,res=64)
-	layout(matrix(c(1,1,2,2),2,2),widths=c(0.85,0.15))
+	layout(matrix(c(1,1,2,2),2,2),widths=c(0.715,0.285))
 	par(mar=c(5,4,4,2)+0.1) 
 	par(lab=c(10,10,7))
 	plot(p,type="o",plot.type="single",col=1:18,pch=pch,xlab="date",
@@ -45,7 +45,7 @@
 	axis(4)
 	plot.new()
 	par(plt=c(0,1,0,1))        
-	legend(-1.2,1, arch, col=1:18, pch=pch, lwd=2, bg='gray90', cex=1.5)  
+	legend('topright', arch, col=1:18, pch=pch, lwd=2, bg='gray90', cex=1.5)  
 }
 v <- readdata("/srv/wanna-build/etc/graph-data",164)
 plotwb("/srv/buildd.debian.org/web/stats/graph.png","What percent is built for each architecture",v,85,7.5,10,".")

signature.asc
Description: PGP signature