On Fri, Jul 10, 2020 at 10:47:14PM +0200, Michel Le Bihan wrote: > In dark GTK themes the caption background correctly changes to the dark color, > but the text stays black resulting in it being unreadable. The text color > should also change. > > I opened a PR upstream https://github.com/wxWidgets/wxWidgets/pull/1791 and my > changes got merged in > https://github.com/AliKet/wxWidgets/commit/1e25f0d966b7539fee93a67671f7834db38c3d5c. > I think that this change should be backported to the version of wxWidgets in > testing because currently some wxWidgets apps are barely usable with a dark > GTK > theme.
Has this patch been backported to upstream's WX_3_0_BRANCH branch? It's been so long since this branched that most patches against upstream master won't cleanly apply to 3.0.x, so while you've linked to a patch for this, that patch isn't actually usable as-is for the package because it doesn't apply cleanly: $ wget https://github.com/AliKet/wxWidgets/commit/1e25f0d966b7539fee93a67671f7834db38c3d5c.diff [...] $ patch -p1 < 1e25f0d966b7539fee93a67671f7834db38c3d5c.diff patching file src/aui/auibar.cpp Hunk #1 succeeded at 89 (offset 2 lines). Hunk #2 succeeded at 155 (offset 11 lines). Hunk #3 succeeded at 314 (offset -20 lines). Hunk #4 succeeded at 334 (offset -20 lines). Hunk #5 FAILED at 363. Hunk #6 succeeded at 432 (offset -25 lines). Hunk #7 succeeded at 451 (offset -25 lines). Hunk #8 FAILED at 501. Hunk #9 succeeded at 680 (offset -44 lines). 2 out of 9 hunks FAILED -- saving rejects to file src/aui/auibar.cpp.rej can't find file to patch at input line 130 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |diff --git a/src/aui/barartmsw.cpp b/src/aui/barartmsw.cpp |index 7958f810db2..878aafce5ae 100644 |--- a/src/aui/barartmsw.cpp |+++ b/src/aui/barartmsw.cpp -------------------------- File to patch: Skip this patch? [y] Skipping patch. 2 out of 2 hunks ignored patching file src/aui/dockart.cpp Hunk #1 FAILED at 324. 1 out of 1 hunk FAILED -- saving rejects to file src/aui/dockart.cpp.rej It's probably OK that src/aui/barartmsw.cpp doesn't exist from a Debian perspective, as from the name it's MSW-specific, but the failed hunks need sorting out. But overall I'd encourage getting this fixed in upstream's WX_3_0_BRANCH first (or linking to that commit if it's already backported). That way this gets fixed for all distros, not just Debian-based ones. Cheers, Olly
