Package: smartmontools
Version: 7.1-1
Severity: minor
A bug report against fteqcc (#968524) prompted me to look for other
instances of the same anti-pattern on codesearch.debian.net. It looks
as though smartmontools is *mostly* a false positive, but there are some
improvements that could be made.
d/rules in smartmontools sets INSTALL_PROGRAM to 'install -s'. However,
this variable doesn't actually seem to be used for anything: if it was,
presumably no -dbgsym package would have been produced. I would suggest
just not setting it.
If there is a use that I have missed, invoking 'install -s' is usually
only harmful for a Debian package, not helpful: it discards debugging
symbols that could otherwise have gone into a -dbgsym package, and when
cross-compiling it uses the wrong strip(1) implementation (from the build
rather than host architecture). INSTALL_PROGRAM = install would likely be
better.
Similarly, smartmontools appends either -O0 or -O2 to CFLAGS, but there's
no need to do that, because dpkg-buildflags already chooses one of those
as appropriate for the presence or absence of noopt in DEB_BUILD_OPTIONS.
smcv
