Source: r-cran-remotes
Version: 2.2.0-1
Severity: normal
Tag: patch

Dear Maintainer,

r-cran-remotes has not migrated to testing because of a regression detected by 
autopkgtest:

https://ci.debian.net/data/autopkgtest/testing/amd64/r/r-cran-remotes/6968122/log.gz

This is the important part:


── 1. Error: install-github.R script is up to date (@test-script.R#5)  ─────────
there is no package called ‘covr’
Backtrace:
  1. testthat::skip_if(covr::in_covr())
  3. covr::in_covr
  4. base::getExportedValue(pkg, name)
  5. base::asNamespace(ns)
  6. base::getNamespace(ns)
  7. base::loadNamespace(name)
  8. base::withRestarts(stop(cond), retry_loadNamespace = function() NULL)
  9. base:::withOneRestart(expr, restarts[[1L]])
 10. base:::doWithOneRestart(return(expr), restart)

── 2. Failure: system_requirements error if no package exists (@test-system_requ
`system_requirements("ubuntu", "16.04", pkg)` threw an error with unexpected 
message.
Expected match: "must contain a package"
Actual message: "`curl` must be on the `PATH`."
Backtrace:
 1. testthat::expect_error(...)
 6. remotes::system_requirements("ubuntu", "16.04", pkg)

── 3. Failure: system_requirements error if no package exists (@test-system_requ
`system_requirements("ubuntu", "16.04", pkg)` threw an error with unexpected 
message.
Expected match: "must contain a package"
Actual message: "`curl` must be on the `PATH`."
Backtrace:
 1. testthat::expect_error(...)
 6. remotes::system_requirements("ubuntu", "16.04", pkg)

══ testthat results  ═══════════════════════════════════════════════════════════
[ OK: 416 | SKIPPED: 88 | WARNINGS: 0 | FAILED: 3 ]
1. Error: install-github.R script is up to date (@test-script.R#5) 
2. Failure: system_requirements error if no package exists 
(@test-system_requirements.R#4) 
3. Failure: system_requirements error if no package exists 
(@test-system_requirements.R#12) 



The DEP-8 test is missing 2 dependencies: covr and curl. I attached a patch 
adding those 2 missing test dependencies to d/t/control. I tested this patch 
locally and autopkgtest is happy with it.

Thanks in advance for considering the patch!

-- 
Lucas Kanashiro

From 894ed498c6279c1f37e9994820e8c52766502955 Mon Sep 17 00:00:00 2001
From: Lucas Kanashiro <kanash...@ubuntu.com>
Date: Thu, 10 Sep 2020 09:43:21 -0300
Subject: [PATCH 1/1] d/t/control: add dependency on r-cran-covr and curl

---
 debian/tests/control | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/tests/control b/debian/tests/control
index 554975a..6be6afa 100644
--- a/debian/tests/control
+++ b/debian/tests/control
@@ -1,3 +1,3 @@
 Tests: run-unit-test
-Depends: @, r-cran-testthat, r-cran-codetools, r-cran-mockery, r-base-dev
+Depends: @, r-cran-testthat, r-cran-codetools, r-cran-mockery, r-base-dev, r-cran-covr, curl
 Restrictions: allow-stderr
-- 
2.25.1

Reply via email to