Hi,
On 22/09/2020 11:47, Tobias Frost wrote: > Control: tags -1 moreinfo Cleared > On Tue, Sep 22, 2020 at 10:58:26AM +0200, Alec Leamas wrote: > > Hi Alec, > > To avoid confustion, I'm comparing the version in the archive (1.2.1-1.1) with > yours, in case you missed the NMU. Which is exactly what I did... > - d/changelog you need to include the changelog of the NMU in your > changelog. Done > - d/copyright: Can you add the upstream contact? Done > You probably also want to update the years on the debian section. Done > - d/control: you re-adding python-catkin-pkg as B-D. Is it needed? > (asking, as #943082 says no) Indeed. Dropped. > - d/rules: in the dh_override_auto_configure: you don't need to repeat > the buildsystem parameter. Done. > - (not required for upload) > not sure if you really need the 0007 patch; verbose builds should be > enabled automatically. (If not, you probably want to pass > -DCMAKE_VERBOSE_MAKEFILE=On the dh_override_auto_configure > (patches patching CMakeLists.txt will break on every upstream release, > in my experience. Or TL;DL: It's PITA). Silly one, this. Of course it should be done using a parameter to cmake rather than a patch. Fixed. I need to upstream the CMake changes, there is actually a lot. But it's a bit complicated, need to refactor the first patch into separate, manageable ones. OTOH, upstream doesn't seem to release that often. > For later (as this requires a trip though NEW), maybe you want to put > the doxygen documentation on a arch:all -doc package? Hm... I know I actually considered this. On Fedora, the separate -doc package is a nobrainer. However, I have understood that on Debian "too" small packages are not really welcome. Here, the docs are about 450K in 40 files. Is this enough for a package to not be too small? What is really "small" in this context? > Only minor changes required ;-) Good job! hmpf. Missing the NMU wasn't minor, for sure. "depressed" Cannot upload to mentors: $ dput -f mentors ../libcxx-serial_1.2.1-2_source.changes Checking signature on .changes gpg: ../libcxx-serial_1.2.1-2_source.changes: Valid signature from 0A1DA7134E068B4C Checking signature on .dsc gpg: ../libcxx-serial_1.2.1-2.dsc: Valid signature from 0A1DA7134E068B4C Uploading to mentors (via ftp to mentors.debian.net): Uploading libcxx-serial_1.2.1-2.dsc: 553 Could not create file. Leaving existing libcxx-serial_1.2.1-2.dsc on the server and continuing And now, what? "confused" Many thanks for reviewing! Cheers! --alec PS: As long as it is possible in any way, I'm avoiding the NEW queue. Have been waiting there more than a year... DS