On Mon, Sep 28, 2020 at 09:18:56AM +0100, Simon McVittie wrote: > On Mon, 28 Sep 2020 at 13:20:59 +1000, James Cameron wrote: > > I've just tested Debian Testing (Bullseye), with src:sugar > > 0.117-3, src:sugar-artwork:0.117-1, src:sugar-terminal-activity > > version 47-1, src:vte2.91 version 0.62.0-1, and GTK 3.24.23-1 but > > do not see any problem. > > > > The terminal is correctly rendered in black on white or white on > > black modes. > > If sugar-terminal-activity hard-codes its background colour, you > wouldn't see a problem.
Yes, sugar-terminal-activity hard-codes background colour of the Vte. > The problem case is when vte is configured to inherit its colours > from the theme. I don't know whether this is even possible with > sugar-terminal-activity, but it is possible in gnome-terminal: > https://gitlab.gnome.org/GNOME/vte/-/issues/284 > > Note that src:vte2.91 0.62.0-2 has a workaround, so you will need to > hold src:vte2.91 at version 0.62.0-1 to reproduce this. Upstream > asked me not to apply the workaround on the 0.63.x branch, so it is > likely to go away after bullseye. Yes, I checked that I used src:vte2.91 0.62.0-1 after seeing your later changes on salsa git. Thanks for warning, and sorry for not mentioning. > To reproduce this in GNOME (I used a test VM): > - Run a gnome-terminal and gnome-tweaks > - In gnome-terminal, right-click -> Preferences > - profile -> Colors -> Text and Background -> Use colors from system > theme > - In gnome-tweaks: Appearance -> Themes -> Applications -> > Sugar-100 or Sugar-72 > - Drag the two windows around to see the misrendering Thanks. It does reproduce. > (I realise the Sugar themes are probably not *intended* to be used > to theme non-Sugar GTK-based environments like GNOME and XFCE, but > there is nothing that prevents it!) Yes, an unexpected outcome. Perhaps we should make the theme local to Sugar and activities rather than make it available for other uses. > The client-side-decoration window titlebar seems to have the same > issue, so there are probably other named colours missing? Depending > on the age of the theme, you might also need to add > @theme_text_color and @unfocused_insensitive_color. See > gtk/theme/Adwaita/_colors-public.scss in the gtk+3.0 source package > for the full set. Thanks. I added these, which further fixed the Vte rendering, making gnome-terminal useful again. Window titlebar rendering was still broken, even after I added _all_ remaining named colors from the full set. I don't know what is missing. https://github.com/sugarlabs/sugar-artwork/pull/118 > > Please review > > https://github.com/sugarlabs/sugar-artwork/pull/117 > > That looks suitable, although I haven't tested it. > > smcv -- James Cameron http://quozl.netrek.org/