Source: sound-juicer
Version: 3.38.0-1
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
Hi,
Whilst working on the Reproducible Builds effort [0] we noticed that
sound-juicer could not be built reproducibly.
This is because the binary embeds an absolute path to the
data/rhythmbox.gep file, presumably so that the file can be located
from a development/git checkout or similar.
As this is not necessary (and won't ever resolve) in a regular Debian
context, the attached patch replaces the reference to the absolute
build directory to ".", i.e. the current directory.
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`---- a/debian/patches/reproducible-build.patch 1970-01-01 01:00:00.000000000
+0100
--- b/debian/patches/reproducible-build.patch 2020-10-12 10:59:51.298141205
+0100
@@ -0,0 +1,15 @@
+Description: Make the build reproducible
+Author: Chris Lamb <la...@debian.org>
+Last-Update: 2020-10-12
+
+--- sound-juicer-3.38.0.orig/libjuicer/rb-gst-media-types.c
++++ sound-juicer-3.38.0/libjuicer/rb-gst-media-types.c
+@@ -34,7 +34,7 @@
+
+ #include "rb-gst-media-types.h"
+
+-#define SOURCE_ENCODING_TARGET_FILE TOPSRCDIR"/data/rhythmbox.gep"
++#define SOURCE_ENCODING_TARGET_FILE "./data/rhythmbox.gep"
+ #define INSTALLED_ENCODING_TARGET_FILE DATADIR"/sound-juicer/rhythmbox.gep"
+ static GstEncodingTarget *default_target = NULL;
+
--- a/debian/patches/series 2020-10-12 10:56:07.851134588 +0100
--- b/debian/patches/series 2020-10-12 10:59:50.382128946 +0100
@@ -1,3 +1,4 @@
metainfo-no-network.patch
Fix-showing-icon-in-the-about-dialog.patch
build-fix-doc-directory.patch
+reproducible-build.patch
