I just re-generated the two patches with the option "-u" to diff to make them more readable.

Le 12/10/2020 à 15:10, Alex ARNAUD a écrit :
Package: hplip
Severity: wishlist patch
Tags: ||buster||

Hello,

Why I'd like this to be backported to buster-backports ?
My new printer, an HP 2700 series is only compatible with HP Lip 3.20.5+. This is based on my own tests where only half of printed pages are printed. This is also based on the upstream table <https://developers.hp.com/hp-linux-imaging-and-printing/supported_devices/index> where it is indicated the "HP DeskJet 2700 All-in-One Printer series" is compatible with 3.20.5.

What did I already do to figure this out?
With the help of Samuel Thibault, I was able to recompile HP Lip 3.20.5 on a Buster virtual machine and I produced two patch for it. The patches are attached to this mail. One is to update the debian/patches/series file and the second one is to refresh the patch 0072 (just a quilt refresh on it). I initially would like to propose a pull request on Salsa but there is no branch to submit the changes.

What my patch does?
It reverts all the python3.8 specific patches because Debian Buster is based on Python 3.7 and because python3.7 library is named "python3.7m", not only python3.7.

What I think HP Lip should be backported to buster-backports?
I think it'd be really helpful for people would like to stay on stable with new HP printers which require new HP Lip to have a new version in backports.

How do I check if it works?
1. I upgraded the compiled packages with the following command:
sudo dpkg -iO .../*.deb

2) I rebooted my virtual machine to ensure the new HP Lip version is loaded

3) I configured my HP Desktop 3630 printer (launched with system-config-printer)

4) I tried a print test job launched with system-config-printer

5) I tried a scan with simple-scan

Result:
Everything seems to work correctly.

Thanks in advance,
Alex.


--- ../hplip-3.20.5+dfsg0.orig/debian/patches/series	2020-10-12 14:43:13.346892324 +0200
+++ debian/patches/series	2020-10-12 14:47:20.678512933 +0200
@@ -68,7 +68,4 @@
 0068-abrt-hplip-strlen-hp-killed-by-SIGSEGV.patch
 0069-abrt-hp-systray-BlockingIOError-Errno-11-Resource-te.patch
 0070-Missing-drivers.patch
-0071-Fix-building-with-Python-3.8.patch
 0072-Fix-upstream-CFLAGS-override.patch
-0073-py3.8-Fix-SyntaxWarning-is-is-not-with-a-literal.patch
-0074-py3.8-Assume-the-python3-distro-package-is-available.patch
--- ../hplip-3.20.5+dfsg0.orig/debian/patches/0072-Fix-upstream-CFLAGS-override.patch	2020-10-12 14:43:13.346892324 +0200
+++ debian/patches/0072-Fix-upstream-CFLAGS-override.patch	2020-10-12 14:44:03.893473185 +0200
@@ -10,11 +10,11 @@
  configure.in | 36 +++++++++++++++++++++++-------------
  1 file changed, 23 insertions(+), 13 deletions(-)
 
-diff --git a/configure.in b/configure.in
-index 7f6982c..ced1f47 100755
---- a/configure.in
-+++ b/configure.in
-@@ -604,20 +604,31 @@ if test "$class_driver" = "no" && test "$hpijs_only_build" = "no" && test "$hpcu
+Index: hplip-3.20.5+dfsg0/configure.in
+===================================================================
+--- hplip-3.20.5+dfsg0.orig/configure.in
++++ hplip-3.20.5+dfsg0/configure.in
+@@ -604,20 +604,31 @@ if test "$class_driver" = "no" && test "
     fi
  fi
  
@@ -58,9 +58,9 @@
  if test "$class_driver" = "no" && test "$hpijs_only_build" = "no" && test "$lite_build" = "no" && test "$hpcups_only_build" = "no"; then
     AC_ARG_VAR([PYTHON], [Python interpreter/compiler command])
     AM_PATH_PYTHON([2.2])
-@@ -633,7 +644,6 @@ if test "$class_driver" = "no" && test "$hpijs_only_build" = "no" && test "$lite
+@@ -630,7 +641,6 @@ if test "$class_driver" = "no" && test "
+    AS_IF([test "x$FOUND_HEADER" != "xyes"],
            [AC_MSG_ERROR([cannot find python-devel support], 6)])
-    CPPFLAGS=$save_CPPFLAGS
  fi
 -CFLAGS="$save_CFLAGS"
  

Reply via email to