Sure. I don't think having a separate reimplementation of Xsession is a good idea (rather than reusing it), for exactly this kind of reason; this would break with any future enhancements to Xsession as well. But for compatibility, until that version of Xsession defines `has_option` appropriately as well, we *could* move the various helper functions and variables from Xsession to something like /usr/share/X11/Xsession-common, have it detect if it's already been sourced so that it only initializes once, and then source that from the various scripts as well as from /etc/X11/Xsession itself. That'll fix this issue.
- Josh Triplett On Thu, Oct 15, 2020 at 05:00:53PM +0300, Timo Aaltonen wrote: > Josh, please have a look at this, is it possible to fix without reverting > support for Xsession.d? > > On 15.10.2020 15.51, Andrey Kiselev wrote: > > Package: x11-common > > Followup-For: Bug #963059 > > > > Dear Maintainer, > > > > The fix coming with the 1:7.7+21 now breaks users resource loading in the > > gdm3 session. gdm3 has its own Xsession script which was not updated to > > reflect the changes introduced in latest x11-common. It looks like this in > > logs: > > > > Oct 15 12:13:29 rose /usr/libexec/gdm-x-session[2516]: /etc/gdm3/Xsession: > > Beginning session setup... > > Oct 15 12:13:29 rose /usr/libexec/gdm-x-session[2516]: /etc/gdm3/Xsession: > > 16: /etc/X11/Xsession.d/30x11-common_xresources: has_option: not found > > > > There is a possibility that some other session managers can be the same way > > affected. > > > > I think that the quick fix is to move has_option() function back into the > > "20x11-common_process-args" file. > > > > Best regards, > > Andrey > > > > -- System Information: > > Debian Release: bullseye/sid > > APT prefers testing > > APT policy: (500, 'testing') > > Architecture: amd64 (x86_64) > > Foreign Architectures: i386 > > > > Kernel: Linux 5.8.0-2-amd64 (SMP w/8 CPU threads) > > Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE > > Locale: LANG=ru_RU.utf8, LC_CTYPE=ru_RU.utf8 (charmap=UTF-8), LANGUAGE not > > set > > Shell: /bin/sh linked to /bin/dash > > Init: systemd (via /run/systemd/system) > > LSM: AppArmor: enabled > > > > Versions of packages x11-common depends on: > > ii lsb-base 11.1.0 > > > > x11-common recommends no packages. > > > > x11-common suggests no packages. > > > > -- no debconf information > > > > > -- > t
