reassign 955994 src:xen tags 955994 + pending thanks Hi Samuel,
On 4/5/20 9:14 PM, Samuel Thibault wrote: > Package: xen-utils-common > Version: 4.11.3+24-g14b62ab3e5-1 > Severity: normal > Tags: patch > > Hello, > > I was having issues with starting domains with vif-nat: > > ♭ xl cr -c mydom > Parsing config from mydom > libxl: error: libxl_exec.c:117:libxl_report_child_exitstatus: > /etc/xen/scripts/vif-nat online [27191] exited with error status 1 > libxl: error: libxl_device.c:1286:device_hotplug_child_death_cb: script: > /etc/xen/scripts/vif-nat failed; error detected. > libxl: error: libxl_create.c:1519:domcreate_attach_devices: Domain 25:unable > to add vif devices > libxl: error: libxl_domain.c:1034:libxl__destroy_domid: Domain > 25:Non-existant domain > libxl: error: libxl_domain.c:993:domain_destroy_callback: Domain 25:Unable to > destroy guest > libxl: error: libxl_domain.c:920:domain_destroy_cb: Domain 25:Destruction of > domain failed > > It happens that it seems that's merely because handle_iptable() does not > pass a return value, and I guess the return value is thus that of the > latest command, which may not be true, and that makes vif-nat fail. The > attached patch fixes that. Yes, you are completely right. Thanks for spotting this. > [...] I just added the explicit 0. I did not change the second return line, since that code is unreachable anyway and it's patching upstream content. https://salsa.debian.org/xen-team/debian-xen/-/commits/knorrie/sid Thanks, Hans
