Control: tag -1 + pending Hi Maciej,
Axel Beckert wrote: > Maciej Bonin wrote: > > I have noticed that my PC is being flagged as having broken ntp > > settings after the update of ntp to 1:4.2.8p14+dfsg-1 in sid. > > Hmmm, didn't notice any issues with my Sid installations. But then > again, I migrated mostly to ntpsec instead of ntp. Ok, I was able to reproduce this now. > > New ntp version seems to ship with updated ntpq output. To be more precisely: The positive offsets now sport a leading plus sign. > > I am attaching a patch, but it's a bit of a hatchet job. Please > > check if I didn't change something else unintentionally. > > Will have a look, Thanks for the patch! Didn't apply, but that only seemed whitespace related issues. Since I wasn't happy with some details (backslash in front of the plus is unnecessary, the plus is solely needed in the offset column, I made my own minimal patch for it: - } elsif ($line =~ /^\*\S+\s+\S+\s+\d+ \w\s+[\dm-]+\s+[\d-]+\s+[\d-]+\s+([\d\.-]+)\s+([\d\.-]+)\s+([\d\.-]+)/) { + } elsif ($line =~ /^\*\S+\s+\S+\s+\d+ \w\s+[\dm-]+\s+[\d-]+\s+[\d-]+\s+([\d\.-]+)\s+([-\d\.+]+)\s+([\d\.-]+)/) { Will be in the next upload which will happen soon. Regards, Axel -- ,''`. | Axel Beckert <a...@debian.org>, https://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5 `- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE