Control: tags -1 pending thanks Hello Carles,
I finally picked up some commits with additional small modifications from my side. I dropped all the removing of currently not used debugging possibilities you have done because I still have the hope that at one day $SOMEONE can add valgrid as option and secondly the removing isn't helping or fixing any broken thing. Removing means that people will need to start from scratch at that point, I see no gain in removing things that increase the contribution barrier. After some other things I'll push the current local tree to Salsa. The modifications will go into 78.7.0 which will happen around the end of January. Am 08.12.20 um 12:38 schrieb Carles Pina i Estany: > > Hello Carsten, > > On Nov/18/2020, Carsten Schoenert wrote: >> Hello Carles, >> >> Am 18.11.20 um 09:44 schrieb Carles Pina i Estany: >>> Next weeks I will have some time. I'd be happy to have another look at >>> this. >>> >>> This branch (old, 6 months) should fix the bug: >>> https://salsa.debian.org/carlespina/thunderbird/-/commit/591c13324a102e8ae8ebaadfdc11d3a9dbffecbc >> >> unfortunately I'm constantly busy since the start of the Corona pandemic >> and I'm glad as long I'm able to follow the normal releases of Thunderbird. > > no problem at all! I mentioned the 6 months as a reminder that we had > looked at this, not as a complain at all. I should admit taht I had > forgotten of it until I saw the new Thunderbird relases recently (and > that I have a bit more of time these weeks). > >>> You mentioned vagrant in your last message but I failed to see how >>> vagrant is used and if this variable is needed (it can be set with >>> "thunderbird -g"). >> >> The intention here was simply that we don't need to rework the whole >> thing at the day we need or want to implement support for this. But of >> course there isn't anything added yet to this reference. OTOH nobody >> ever came up with a need for this since more than two years. > > I understand, thanks! > >>> I'm happy to rename the variables if this was the >>> preferred option (prefixed with TB_ for THUNDERBIRD_) or any other >>> possible fix. >> >> Just start / work further with what you prefer, search and replace >> should be a thing of minutes if needed. > > It's a small fix (once identified the problem) so if you have something > in mind please go ahead :-) as long as people don't have problems with > having "export DEBUG=1" and then Thunderbird failing to run it will be > good (it did confuse me for a while at my partner's computer). > > Either way, if it helps: > Option 1: renaming variables non-intrusive commit (I hope): > https://salsa.debian.org/carlespina/thunderbird/-/commit/6661e140ea793deaeab4d583f345bb914e8b53ef > > Option 2: unsets variables (I think that non-intrusive as well) > https://salsa.debian.org/carlespina/thunderbird/-/commit/591c13324a102e8ae8ebaadfdc11d3a9dbffecbc > > Option 3: a series of cleanups that I had done in May while understanding the > wrapper: > https://salsa.debian.org/carlespina/thunderbird/-/commits/thunderbird-launcher-variables/ > > If I could help in anything just let me know. > > And thanks very much for your work on Thunderbird :-) it's a big package > (I can say after using git :-) ) > -- Regards Carsten
