Control: severity 948346 serious

On Tue, 04 Aug 2020 11:49:17 +0300 =?UTF-8?B?QWxleGFuZGVyIEtsaW1vdg==?= 
<alser...@inbox.ru> wrote:
>
> The attached seems to work on buster.

Thanks for the patch, also thanks to Bernhard for investigation.

The patch could be used but it just working around symptoms. I see
multiple bugs involved here.

a) logrotate job using a plain kill. This is racy, even with SysV init.
We can do it better (systemctl kill function).

b) service file not cleaning up the pid file. That file should be gone
even when service terminates.

c) xdm refusing to start when the pid file exists, although the process
is no longer running. It could check whether it's still active, and/or
maybe just kill it and evaluate the errno.

I am setting this to RC severity because it's just NOT ok and obvious to
fix. Going to change mentioned things and NMU this in a couple of weeks
if there is no further reaction from maintainers.

Best regards,
Eduard.

--
Atheismus ist keine Philosophie, er ist noch nicht ein mal eine
Weltsicht. Er ist schlichtweg die Weigerung, ohne Grund das Gegenteil
des Offensichtlichen zu glauben.

Reply via email to