On Sun, 31 Jan 2021 00:22:25 +0300 Nicholas Guriev <guriev...@ya.ru> wrote: > Hello! > > On Sat, 2021-01-30 at 21:54 +0100, Paul Gevers wrote: > > You recently added an autopkgtest to your package xdg-utils, great. > > However, it fails. Currently this failure is blocking the migration to > > testing [1]. Can you please investigate the situation and fix it? > > There are several ways to fix the failure. > > 1. Replace `debian/rules patch` line in a test script with `chmod +x > autotests/tty{on,off}`. > > --- a/debian/tests/entry > +++ b/debian/tests/entry > @@ -13,6 +13,6 @@ fi > BASH_XTRACEFD=1 > set -x > ยท > -debian/rules patch > ./configure > +chmod +x autotests/tty{on,off} > make autotest SHELL="${1:-/bin/sh}" > > https://salsa.debian.org/freedesktop-team/xdg-utils/-/commit/9928933504932f19fb39a0f671cdc7be78aada29 > > 2. Put the "patch" target back as it was in -3 revision, and fix arch- > independent build. > > https://salsa.debian.org/freedesktop-team/xdg-utils/-/merge_requests/4/diffs?commit_id=0617f9284ae4d79b51c4ad4bc7d781e93561cb23 > > I still prefer the later option with the "patch" target. Because that > chmod fixes flaws of quilt and dpkg and this solutions is more > universal. I hope someone will choose to upload another one-liner fix.
Please drop patching from the test entirely. autopkgtests are supposed to _start_ running against a fully patched source tree. autopkgtest(1) does this automatically. I understand that this might be convenient when working on the package, but please automate it in a way that it's not also done when running the autopkgtest "for real".
signature.asc
Description: PGP signature