On Sun, Feb 28, 2021 at 11:00 pm, Pirate Praveen <prav...@onenetbeyond.org> wrote:
On Sun, 28 Feb 2021 19:04:24 +0530 Pirate Praveen <prav...@onenetbeyond.org> wrote:
> Asking upstream for help
> https://gitlab.com/gitlab-org/gitlab/-/issues/323024

Removing these 3 files makes the upgrade to proceed,
/usr/share/gitlab/config/feature_flags/ops/api_kaminari_count_with _limit.yml
/usr/share/gitlab/config/feature_flags/licensed/resource_access_token.yml
/usr/share/gitlab/config/feature_flags/ops/marginalia.yml

Of these 3 /usr/share/gitlab/config/feature_flags/licensed/resource_access_token.yml
can definitely be removed as it is not present in current version.

I think these are safe to remove, but I will wait a few days for an answer from upstream (till there is a new security release).

Or if someone else can confirm, this is safe, I can remove it as well.

ok, so the remaining two were also present in /usr/share/gitlab/config/feature_flags/development and were obsolete.

I confirmed the upgrade goes smooth after removing these and all other obsolete initializers. I have also implemented a check during build if any files in config is changed or not.

Moving 'config' directory out of /etc would be another option, but then that will need us to move files we would like users or package to be able to modify to /etc/gitlab manually (database.yml, gitlab.yml and some more .rb files like puma.rb). If anyone wants to give it a try, feel free.

Reply via email to