Package: release.debian.org Severity: normal User: release.debian....@packages.debian.org Usertags: unblock X-Debbugs-Cc: t...@mirbsd.de
Please unblock package musescore2, musescore3, musescore-general-soundfont and timgm6mb-soundfont (all packages related to #984592) [ Reason ] In rare conditions, “rmdir --ignore-fail-on-non-empty” as used in the prerm of some packages can fail because dpkg already removed one of the directories in question; this was found as #984592 by piuparts. To ensure uninstalling without errors, we mkdir -p the directories first (other errors will still cause aborting). [ Impact ] #984592 is considered an RC bug, so it would lead to removing a package from the release, which is very suboptimal. In very rare cases, not fixing this may cause package uninstallation to fail. [ Tests ] None; the code is trivial. [ Risks ] No risk, this is trivial. [ Checklist ] [x] all changes are documented in the d/changelog [x] I reviewed all changes and I approve them [x] attach debdiff against the package in testing [ Other info ] I have another set of uploads for musescore2 and musescore3 fixing crash bugs coming up (not uploading them today, I want upstream to have a go at reviewing the change first). How should this be handled? Should I first wait until the current set of packages is unblocked and has migrated to testing? Otherwise, if I upload now musescore2 would get AUTORM’d which is suboptimal. Waiting so long will however delay availability of the fix even to sid users. unblock musescore2/2.3.2+dfsg4-14 unblock musescore3/3.2.3+dfsg2-10 unblock musescore-general-soundfont/0.2-3 unblock timgm6mb-soundfont/1.3-5
diff -Nru musescore-general-soundfont-0.2/debian/changelog musescore-general-soundfont-0.2/debian/changelog --- musescore-general-soundfont-0.2/debian/changelog 2020-07-12 17:02:25.000000000 +0200 +++ musescore-general-soundfont-0.2/debian/changelog 2021-03-12 20:58:58.000000000 +0100 @@ -1,3 +1,12 @@ +musescore-general-soundfont (0.2-3) unstable; urgency=medium + + * Bump Policy (no relevant changes) + * Avoid rare error in prerm (Closes: #984592) + * Update from maintainer script template + * Do latest lintian tag rename churn + + -- Thorsten Glaser <t...@mirbsd.de> Fri, 12 Mar 2021 20:58:58 +0100 + musescore-general-soundfont (0.2-2) unstable; urgency=high * Merge musescore-general-soundfont-small (0.2-2) changes diff -Nru musescore-general-soundfont-0.2/debian/control musescore-general-soundfont-0.2/debian/control --- musescore-general-soundfont-0.2/debian/control 2020-05-28 23:19:04.000000000 +0200 +++ musescore-general-soundfont-0.2/debian/control 2021-03-12 20:34:13.000000000 +0100 @@ -5,7 +5,7 @@ Homepage: https://musescore.org/en/node/269869 Build-Depends: debhelper-compat (= 13), python3-minimal, sf3convert -Standards-Version: 4.5.0 +Standards-Version: 4.5.1 Rules-Requires-Root: no VCS-git: https://evolvis.org/anonscm/git/alioth/soundfonts.git -b musescore-general-soundfont VCS-Browser: https://evolvis.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=alioth/soundfonts.git;a=shortlog;h=refs/heads/musescore-general-soundfont diff -Nru musescore-general-soundfont-0.2/debian/musescore-general-soundfont-lossless.postinst musescore-general-soundfont-0.2/debian/musescore-general-soundfont-lossless.postinst --- musescore-general-soundfont-0.2/debian/musescore-general-soundfont-lossless.postinst 2020-05-28 23:00:17.000000000 +0200 +++ musescore-general-soundfont-0.2/debian/musescore-general-soundfont-lossless.postinst 2021-03-12 20:45:47.000000000 +0100 @@ -21,9 +21,12 @@ # # * postinst "triggered" "${triggers[*]}" # For trigger-only calls, i.e. if "configure" is not called. +# +# * new-postinst "reconfigure" [$most_recently_configured_version](?) +# Treat this as just like "configure" for a future extension by debconf. case $1 in -configure) +(configure|reconfigure) # need the directories existing before update-alternatives mkdir -p /usr/share/sounds/sf2 /usr/share/sounds/sf3 # see #929185 for the history behind this @@ -39,13 +42,13 @@ /usr/share/sounds/sf2/MuseScore_General_Full.sf2 55 ;; -abort-upgrade|abort-remove|abort-deconfigure) +(abort-upgrade|abort-remove|abort-deconfigure) ;; -triggered) +(triggered) ;; -*) +(*) echo >&2 "E: postinst called with unknown subcommand '$1'" exit 1 ;; diff -Nru musescore-general-soundfont-0.2/debian/musescore-general-soundfont-lossless.prerm musescore-general-soundfont-0.2/debian/musescore-general-soundfont-lossless.prerm --- musescore-general-soundfont-0.2/debian/musescore-general-soundfont-lossless.prerm 2020-05-28 23:00:17.000000000 +0200 +++ musescore-general-soundfont-0.2/debian/musescore-general-soundfont-lossless.prerm 2021-03-12 20:46:28.000000000 +0100 @@ -19,7 +19,7 @@ # other constraints the same as above. case $1 in -remove|deconfigure) +(remove|deconfigure) # MuseScore-default-compatible soundfonts update-alternatives --remove MuseScore_General.sf3 \ /usr/share/sounds/sf2/MuseScore_General_Full.sf2 @@ -29,14 +29,17 @@ update-alternatives --remove default-GM.sf2 \ /usr/share/sounds/sf2/MuseScore_General_Full.sf2 # remove directories if they were created in postinst + # mkdir -p them first so that rmdir doesn’t fail if they don’t exist + mkdir -p \ + /usr/share/sounds/sf2 /usr/share/sounds/sf3 rmdir --ignore-fail-on-non-empty \ /usr/share/sounds/sf2 /usr/share/sounds/sf3 ;; -upgrade|failed-upgrade) +(upgrade|failed-upgrade) ;; -*) +(*) echo >&2 "E: prerm called with unknown subcommand '$1'" exit 1 ;; diff -Nru musescore-general-soundfont-0.2/debian/musescore-general-soundfont.postinst musescore-general-soundfont-0.2/debian/musescore-general-soundfont.postinst --- musescore-general-soundfont-0.2/debian/musescore-general-soundfont.postinst 2020-05-28 23:00:17.000000000 +0200 +++ musescore-general-soundfont-0.2/debian/musescore-general-soundfont.postinst 2021-03-12 20:45:48.000000000 +0100 @@ -21,9 +21,12 @@ # # * postinst "triggered" "${triggers[*]}" # For trigger-only calls, i.e. if "configure" is not called. +# +# * new-postinst "reconfigure" [$most_recently_configured_version](?) +# Treat this as just like "configure" for a future extension by debconf. case $1 in -configure) +(configure|reconfigure) # see #929185 for the history behind this update-alternatives --force --install \ /usr/share/sounds/sf3/default-GM.sf3 default-GM.sf3 \ @@ -34,13 +37,13 @@ /usr/share/sounds/sf3/MuseScore_General_Full.sf3 50 ;; -abort-upgrade|abort-remove|abort-deconfigure) +(abort-upgrade|abort-remove|abort-deconfigure) ;; -triggered) +(triggered) ;; -*) +(*) echo >&2 "E: postinst called with unknown subcommand '$1'" exit 1 ;; diff -Nru musescore-general-soundfont-0.2/debian/musescore-general-soundfont.prerm musescore-general-soundfont-0.2/debian/musescore-general-soundfont.prerm --- musescore-general-soundfont-0.2/debian/musescore-general-soundfont.prerm 2020-05-28 23:00:17.000000000 +0200 +++ musescore-general-soundfont-0.2/debian/musescore-general-soundfont.prerm 2021-03-12 20:46:27.000000000 +0100 @@ -19,7 +19,7 @@ # other constraints the same as above. case $1 in -remove|deconfigure) +(remove|deconfigure) # MuseScore-default-compatible soundfonts update-alternatives --remove MuseScore_General.sf3 \ /usr/share/sounds/sf3/MuseScore_General_Full.sf3 @@ -28,10 +28,10 @@ /usr/share/sounds/sf3/MuseScore_General_Full.sf3 ;; -upgrade|failed-upgrade) +(upgrade|failed-upgrade) ;; -*) +(*) echo >&2 "E: prerm called with unknown subcommand '$1'" exit 1 ;; diff -Nru musescore-general-soundfont-0.2/debian/source/lintian-overrides musescore-general-soundfont-0.2/debian/source/lintian-overrides --- musescore-general-soundfont-0.2/debian/source/lintian-overrides 2020-07-12 17:02:25.000000000 +0200 +++ musescore-general-soundfont-0.2/debian/source/lintian-overrides 2021-03-12 20:58:54.000000000 +0100 @@ -1,9 +1,6 @@ # no, thanks musescore-general-soundfont source: no-dep5-copyright -# there are no tests -musescore-general-soundfont source: testsuite-autopkgtest-missing - # upstream uses ever-changing Google Drive links ☹ musescore-general-soundfont source: debian-watch-file-is-missing
diff -Nru musescore2-2.3.2+dfsg4/debian/changelog musescore2-2.3.2+dfsg4/debian/changelog --- musescore2-2.3.2+dfsg4/debian/changelog 2021-01-31 23:05:01.000000000 +0100 +++ musescore2-2.3.2+dfsg4/debian/changelog 2021-03-05 17:57:30.000000000 +0100 @@ -1,3 +1,9 @@ +musescore2 (2.3.2+dfsg4-14) unstable; urgency=medium + + * Fix possible error cause in m-common.prerm (Closes: #984592) + + -- Thorsten Glaser <t...@mirbsd.de> Fri, 05 Mar 2021 17:57:30 +0100 + musescore2 (2.3.2+dfsg4-12) unstable; urgency=medium * Fix CFLAGS/CXXFLAGS extras to disable upstream-only warnings diff -Nru musescore2-2.3.2+dfsg4/debian/musescore-common.prerm musescore2-2.3.2+dfsg4/debian/musescore-common.prerm --- musescore2-2.3.2+dfsg4/debian/musescore-common.prerm 2021-01-31 23:03:52.000000000 +0100 +++ musescore2-2.3.2+dfsg4/debian/musescore-common.prerm 2021-03-05 17:52:41.000000000 +0100 @@ -21,6 +21,9 @@ case $1 in (remove|deconfigure) # remove directories if they were created in postinst + # mkdir -p them first so that rmdir doesn’t fail if they don’t exist + mkdir -p \ + /usr/share/sounds/sf2 /usr/share/sounds/sf3 /usr/share/sounds/sfz rmdir --ignore-fail-on-non-empty \ /usr/share/sounds/sf2 /usr/share/sounds/sf3 /usr/share/sounds/sfz ;;
diff -Nru musescore3-3.2.3+dfsg2/debian/changelog musescore3-3.2.3+dfsg2/debian/changelog --- musescore3-3.2.3+dfsg2/debian/changelog 2021-02-11 02:21:26.000000000 +0100 +++ musescore3-3.2.3+dfsg2/debian/changelog 2021-03-05 17:59:50.000000000 +0100 @@ -1,3 +1,10 @@ +musescore3 (3.2.3+dfsg2-10) unstable; urgency=medium + + * Merge musescore2 (2.3.2+dfsg4-14) unstable; urgency=medium + - fixes rare error in m3-common.prerm (Closes: #984592) + + -- Thorsten Glaser <t...@mirbsd.de> Fri, 05 Mar 2021 17:59:50 +0100 + musescore3 (3.2.3+dfsg2-9) unstable; urgency=medium * backports/plugin-parent.diff: fix crash when traversing from @@ -280,6 +287,12 @@ -- Thorsten Glaser <t...@mirbsd.de> Sun, 27 Jan 2019 17:06:00 +0100 +musescore2 (2.3.2+dfsg4-14) unstable; urgency=medium + + * Fix possible error cause in m-common.prerm (Closes: #984592) + + -- Thorsten Glaser <t...@mirbsd.de> Fri, 05 Mar 2021 17:57:30 +0100 + musescore2 (2.3.2+dfsg4-12) unstable; urgency=medium * Fix CFLAGS/CXXFLAGS extras to disable upstream-only warnings diff -Nru musescore3-3.2.3+dfsg2/debian/musescore3-common.prerm musescore3-3.2.3+dfsg2/debian/musescore3-common.prerm --- musescore3-3.2.3+dfsg2/debian/musescore3-common.prerm 2021-02-01 01:09:00.000000000 +0100 +++ musescore3-3.2.3+dfsg2/debian/musescore3-common.prerm 2021-03-05 17:59:35.000000000 +0100 @@ -21,6 +21,9 @@ case $1 in (remove|deconfigure) # remove directories if they were created in postinst + # mkdir -p them first so that rmdir doesn’t fail if they don’t exist + mkdir -p \ + /usr/share/sounds/sf2 /usr/share/sounds/sf3 /usr/share/sounds/sfz rmdir --ignore-fail-on-non-empty \ /usr/share/sounds/sf2 /usr/share/sounds/sf3 /usr/share/sounds/sfz ;;
diff -Nru timgm6mb-soundfont-1.3/debian/changelog timgm6mb-soundfont-1.3/debian/changelog --- timgm6mb-soundfont-1.3/debian/changelog 2020-08-21 21:51:35.000000000 +0200 +++ timgm6mb-soundfont-1.3/debian/changelog 2021-03-12 20:43:31.000000000 +0100 @@ -1,3 +1,10 @@ +timgm6mb-soundfont (1.3-5) unstable; urgency=medium + + * Team upload. + * Avoid rare error in prerm (Closes: #984592) + + -- Thorsten Glaser <t...@mirbsd.de> Fri, 12 Mar 2021 20:43:31 +0100 + timgm6mb-soundfont (1.3-4) unstable; urgency=medium * Team upload. diff -Nru timgm6mb-soundfont-1.3/debian/timgm6mb-soundfont.prerm timgm6mb-soundfont-1.3/debian/timgm6mb-soundfont.prerm --- timgm6mb-soundfont-1.3/debian/timgm6mb-soundfont.prerm 2020-07-07 18:34:50.000000000 +0200 +++ timgm6mb-soundfont-1.3/debian/timgm6mb-soundfont.prerm 2021-03-12 20:43:29.000000000 +0100 @@ -10,6 +10,9 @@ update-alternatives --remove default-GM.sf2 \ /usr/share/sounds/sf2/TimGM6mb.sf2 # remove directories if they were created in postinst + # mkdir -p them first so that rmdir doesn’t fail if they don’t exist + mkdir -p \ + /usr/share/sounds/sf2 /usr/share/sounds/sf3 rmdir --ignore-fail-on-non-empty \ /usr/share/sounds/sf2 /usr/share/sounds/sf3 ;;