Hi,
> It's invalid C++ to declare a function re-using the same
> parameter name, although gcc accepts it.  Looks like a typo

> -        void line (const GS &gs, int x1, int y2, int x2, int y2);
> +        void line (const GS &gs, int x1, int y1, int x2, int y2);

I guess its fine because it's only in the interface declaration; you
don't need to give any variable names there I think, the signature is
just
void line(const GS&, int, int, int, int);

But I guess upstream will happily apply your diff.

best regards,
Erich Schubert
-- 
    erich@(vitavonni.de|debian.org)    --    GPG Key ID: 4B3A135C    (o_
   It's not denial. I'm just selective about the reality I accept.   //\
    Während das Glück dir lacht, wirst Freunde du zählen in Menge;   V_/_
      wenn sich der Himmel bewölkt, findest du dich bald allein.


Reply via email to