Package: release.debian.org Severity: normal User: release.debian....@packages.debian.org Usertags: unblock
Please unblock (or manually allow transition of) package ensmallen [ Reason ] The previous version was 20+ days old. The only delta here is adding autopkgtest support, which passes fine. Which suggests that this might reasonably be treated as 20+ days old with autopkgtest support. [ Impact ] The version currently in testing has subtle numeric bugs, which seem more likely to manifest on unusual architectures. Since this is numeric software, bugs can silently yield incorrect numeric results. [ Tests ] The autopkgtest test suite is rather comprehensive. [ Risks ] Although in -dev, this is a near-leaf package: only mlpack uses it, and I don't think mlpack will make it into the release. So, no particular risks. [ Checklist ] [X] all changes are documented in the d/changelog [X] I reviewed all changes and I approve them [X] attach debdiff against the package in testing unblock ensmallen/2.16.2-1 ---------------------------------------------------------------- diff -Nru ensmallen-2.16.2/debian/changelog ensmallen-2.16.2/debian/changelog --- ensmallen-2.16.2/debian/changelog 2021-03-25 21:55:13.000000000 +0000 +++ ensmallen-2.16.2/debian/changelog 2021-04-16 16:49:42.000000000 +0100 @@ -1,3 +1,9 @@ +ensmallen (2.16.2-2) unstable; urgency=medium + + * add autopkgtest support + + -- Barak A. Pearlmutter <b...@debian.org> Fri, 16 Apr 2021 16:49:42 +0100 + ensmallen (2.16.2-1) unstable; urgency=medium * New upstream version, WILL fix broken test (closes: #984868) diff -Nru ensmallen-2.16.2/debian/patches/0001-include-path.patch ensmallen-2.16.2/debian/patches/0001-include-path.patch --- ensmallen-2.16.2/debian/patches/0001-include-path.patch 1970-01-01 01:00:00.000000000 +0100 +++ ensmallen-2.16.2/debian/patches/0001-include-path.patch 2021-04-16 16:49:42.000000000 +0100 @@ -0,0 +1,24 @@ +From: "Barak A. Pearlmutter" <barak+...@pearlmutter.net> +Date: Fri, 16 Apr 2021 15:54:22 +0100 +Subject: include path + +The C++ test files must #include <ensmallen.hpp> rather than +"../include/ensmallen.hpp" in order to allow the installed files, +rather than the repo-local files, to be tested. +--- + tests/de_test.cpp | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/tests/de_test.cpp b/tests/de_test.cpp +index a4bb246..c116c69 100644 +--- a/tests/de_test.cpp ++++ b/tests/de_test.cpp +@@ -8,7 +8,7 @@ + * http://www.opensource.org/licenses/BSD-3-Clause for more information. + */ + +-#include "../include/ensmallen.hpp" ++#include <ensmallen.hpp> + #include "catch.hpp" + #include "test_function_tools.hpp" + diff -Nru ensmallen-2.16.2/debian/patches/series ensmallen-2.16.2/debian/patches/series --- ensmallen-2.16.2/debian/patches/series 1970-01-01 01:00:00.000000000 +0100 +++ ensmallen-2.16.2/debian/patches/series 2021-04-16 16:49:42.000000000 +0100 @@ -0,0 +1 @@ +0001-include-path.patch diff -Nru ensmallen-2.16.2/debian/rules ensmallen-2.16.2/debian/rules --- ensmallen-2.16.2/debian/rules 2021-03-04 10:05:57.000000000 +0000 +++ ensmallen-2.16.2/debian/rules 2021-04-16 11:35:59.000000000 +0100 @@ -7,9 +7,13 @@ %: dh $@ +# Number of times to run test suite. +# (There was a heisenbug, and this was used to help track it down.) +n_test = 1 + override_dh_auto_test: ok=true; \ - for i in $$(seq 3); do \ + for i in $$(seq $(n_test)); do \ echo "Test Run $$i"; \ if env CTEST_OUTPUT_ON_FAILURE=1 dh_auto_test; \ then \ diff -Nru ensmallen-2.16.2/debian/tests/control ensmallen-2.16.2/debian/tests/control --- ensmallen-2.16.2/debian/tests/control 1970-01-01 01:00:00.000000000 +0100 +++ ensmallen-2.16.2/debian/tests/control 2021-04-16 16:49:42.000000000 +0100 @@ -0,0 +1,3 @@ +Tests: test-script +Depends: @, g++ | clang | c++-compiler, libarmadillo-dev +Restrictions: allow-stderr diff -Nru ensmallen-2.16.2/debian/tests/test-script ensmallen-2.16.2/debian/tests/test-script --- ensmallen-2.16.2/debian/tests/test-script 1970-01-01 01:00:00.000000000 +0100 +++ ensmallen-2.16.2/debian/tests/test-script 2021-04-16 16:49:42.000000000 +0100 @@ -0,0 +1,10 @@ +#!/bin/sh +set -e +set -x +# Choose location for test executable +e=$(mktemp --tmpdir=${AUTOPKGTEST_TMP} ensmallen-test-XXXXXX) +# Build outside tests to reduce possibility of getting build rather +# than installed ensmallen files via #include. +c++ -O0 -o ${e} tests/*.cpp -lpthread -larmadillo +# cd tests because the executable reads data/* files. +cd tests && ${e} --durations yes