Le 21/04/2021 à 17:23, Pirate Praveen a écrit : > On Wed, 21 Apr 2021 15:48:14 +0200 Yadd <y...@debian.org> wrote: >> Hi, >> >> `pretty=describe` uses the result of `git describe`. You got a >> "4.17.4.20" because this is the last tag on the branch you tried to >> clone. The "4.17.5" tag is attached to a different branch (unnamed). >> >> So uscan is right here ;-) > > I don't think uscan is right here. The correct version is available in > the package.json. I think it'd be a nice option if uscan can pick the > version available in package.json instead of us adding it manually for > every update. I currently have to hard code the version in watch file > which I don't think is a right solution. > > Tag is only one way of finding the version and often not used by node > projects. package.json is also a way to find the version of the node > module and consistently used by all node modules. Since we already have > a type=nodejs we know it has a package.json.
This is not the spirit of HEAD/pretty mode: the goal is to pick commits after last tag. Upstream did a strange thing in this repo: set a tag outside any named branch. I'm not sure we should modify uscan because of an unlikely upstream behavior. But if Devscript Team agree with you, I can modify "ctype" feature to fix tag when last tag is lower than package.json#version, then version will be 4.17.5+timestamp instead of 4.17.4.20+timestamp Cheers, Yadd
