Package: release.debian.org Severity: normal User: release.debian....@packages.debian.org Usertags: unblock
Good Day,
Please unblock package dipy
[ Reason ]
dipy 1.3.0-3 fixes the grave bug #987453, since python3-dipy-lib
is unusable otherwise, and lots of submodules are missing from
python3-dipy. It also addresses the serious bug #987517.
[ Impact ]
Removal of dipy would affect a dozen of users per popcon report.
This is a leaf package, so wouldn't affect buildability nor
installability of other packages in the archive.
[ Tests ]
Automated tests I carried on were those of default Salsa CI.
I'm surprised blhc ended successfully, since resulting shared
objects are missing hardening, per lintian report. autopkgtest
are notably superficial for the moment.
Tests I manually carried on are:
* running dipy_fetch to download some resources, since these
tests are not done automatically in any way anymore;
* testing a couple of commands, such as dipy_align_affine,
or dipy_info, using the result of the download;
* importing some of the missing cython modules to check that
they are now usable, such as dipy.core.interpolation, or
dipy.denoise.shift_twist_convolution.
[ Risks ]
The change to fill properly the package python3-dipy-lib adds a
lot of new cython modules to dipy, which are most likely not
toroughly field tested in Debian context this late in the hard
freeze. Lintian reports a lot of warnings, so the package is
perhaps not in the best shape of the archive. This is a leaf
package, so has very little chance to affect others in the
archive.
[ Checklist ]
[*] all changes are documented in the d/changelog
[*] I reviewed all changes and I approve them
[*] attach debdiff against the package in testing
[ Other info ]
Not being of the field of endeavour myself, my very few testings
may not be representative of normal usage.
unblock dipy/1.3.0-3
Have a nice day, :)
--
Étienne Mollier <etienne.moll...@mailoo.org>
Fingerprint: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da
Sent from /dev/pts/3, please excuse my verbosity.
diff -Nru dipy-1.3.0/debian/changelog dipy-1.3.0/debian/changelog
--- dipy-1.3.0/debian/changelog 2021-01-20 11:52:53.000000000 +0100
+++ dipy-1.3.0/debian/changelog 2021-04-25 11:15:12.000000000 +0200
@@ -1,3 +1,14 @@
+dipy (1.3.0-3) unstable; urgency=medium
+
+ * Team upload.
+ * d/rules: prevent build time test suite from accessing network resources.
+ Closes: #987517
+ * d/rules: install .so files in python3-dipy-lib; this makes several dipy
+ modules, formerly missing, now usable.
+ Closes: #987453
+
+ -- Étienne Mollier <etienne.moll...@mailoo.org> Sun, 25 Apr 2021 11:15:12
+0200
+
dipy (1.3.0-2) unstable; urgency=medium
* Team upload.
diff -Nru dipy-1.3.0/debian/rules dipy-1.3.0/debian/rules
--- dipy-1.3.0/debian/rules 2021-01-20 11:52:53.000000000 +0100
+++ dipy-1.3.0/debian/rules 2021-04-25 10:47:24.000000000 +0200
@@ -57,6 +57,8 @@
# cd build to prevent use of local/not-built source tree
ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
set -x ; \
+ export http_proxy=http://127.0.0.1:9/ ; \
+ export https_proxy=https://127.0.0.1:9/ ; \
for PYTHON in $(PY3VERS); do \
export PYTHONPATH=$$(pybuild --print build_dir --interpreter
python$$PYTHON); \
echo "I: Running Dipy unittests using $$PYTHON"; \
@@ -69,12 +71,17 @@
done
endif
-## remove .so libraries from main package, and call dh_numpy*
+## move .so libraries into -lib package, and call dh_numpy*
## while removing 2 if not present
_dh_python%:
- if [ -d debian/$(PACKAGE$*_NAME)/usr/lib ]; then \
- find debian/$(PACKAGE$*_NAME)/usr/lib -name "*.so" -delete; \
- fi
+ set -e \
+ ; test -d debian/$(PACKAGE$*_NAME)/usr/lib || exit 0 \
+ ; for lib in $$(find debian/$(PACKAGE$*_NAME)/usr/lib -name "*.so") \
+ ; do sdir=$$(dirname $$lib) \
+ ; tdir=debian/$(PACKAGE$*_NAME)-lib/$${sdir#*$(PACKAGE$*_NAME)/} \
+ ; mkdir -p "$${tdir}" \
+ ; mv -v "$${lib}" "$${tdir}" \
+ ; done
[ -e /usr/bin/dh_numpy$(*:2=) ] && dh_numpy$(*:2=)
-p$(PACKAGE$*_NAME)-lib || :
dh_python$*
signature.asc
Description: PGP signature
