Hi, Emilio Pozuelo Monfort <po...@debian.org> (2021-05-07): > On 05/05/2021 07:26, Ryan Tandy wrote: > > [ Tests ] > > > > There are no automated tests. I have been running the updated daemon for > > a few days, and I tested an installation with the updated udeb (using a > > d-i daily image).
I'm very happy to see this was not only build- but also run-tested. > > [ Risks ] > > > > I built the package on buster with and without the patch, to see > > what would change. The disassembly (objdump -d) was the same before > > and after, so I think I can be confident the header was not actually > > used and the patch should not change its behaviour. > > > > However, the package had not been rebuilt since before buster was > > released, so there could be unknown risks arising from rebuilding > > with the newer toolchain. > > > > [ Checklist ] > > > > [✔] all changes are documented in the d/changelog > > [✔] I reviewed all changes and I approve them > > [✔] attach debdiff against the package in testing > > > > [ Other info ] > > > > Very low popcon. The package provides hardware support for a specific > > subset of armel/orion5x NAS devices with few remaining users. > > > > The package builds a udeb. I tested an installation using a daily d-i > > image that includes the update. > > Cyril, can you (n)ack for d-i? Since it seems to be a package that targets specific hardware, and since tests have been carried out on at least one such device, this looks very fine to me. Cheers, -- Cyril Brulebois (k...@debian.org) <https://debamax.com/> D-I release manager -- Release team member -- Freelance Consultant
signature.asc
Description: PGP signature
