On Thu, Apr 20, 2006 at 11:28:28PM +0200, Arnaud Fontaine wrote:
> >>>>> "Stephen" == Stephen Gran <[EMAIL PROTECTED]> writes:
>
> Stephen> The main problem was lost +x perms, most likely due to
> Stephen> patch, and me not noticing that the x bit was lost before
> Stephen> upload. I don't know that wholesale reversion of packaging
> Stephen> decisions is a good thing to do in an NMU.
>
> Stephen> In short, I see that this NMU appears to introduce several
> Stephen> rather major changes that address problems in the bug
> Stephen> report in a rather strange way. Please don't upload yet.
> Stephen> I understand the maintainer (and I, as his sponsor) have
> Stephen> been remiss in not addressing this RC bug.
>
> The +x perm wasn't the main issue, fixing this problem, there was a lot
> of remaining problems with this package (especially debconf
> problems). We have heavily tested this patch (using mysql, pgsql, and
> testing the installation of the package) and it works really fine, in
> addition we have reviewed this patch carefully. So i don't see any
> problem, really, this patch works very well.
>
> Regards,
> Arnaud Fontaine
>
These problems are fixed in 1.0.2-3, my sponsor hasn't had time to review
and upload it.
Why the change from settings.conf back to settings.php? I moved away
from the name 'settings.php' (fixed name in templates in -3) because it
is not a php config file. I also fixed includes/config to reflect this
and permit the use of an alternate settings file to provide support for
having multiple webcalendar confs (eg. for multiple virtual hosts).
The pgsql patch makes no sense. There's no bug report on this, there's no
wishlist item, nothing. Translation from pgsql to postgresql is done in
the postinst so that could not have been causing problems other than some
confusion when comparing what dbconfig-common asks and the name webcalendar
expects.
The last change was to remove dbconfig_oldconf.sh and change
dbc_load_include to 'php:/etc/webcalendar/settings.php' Webcalendar <
1.0.2-1 uses a file called settings.php, but it is not a php file. When
trying to use dbc-load-include -f php /etc/webcalendar/settings.php on that
old conf file it fails. This is the reason for the dbconfig_oldconf.sh, to
translate from the old conf file format to a format that dbconfig-common
can understand. There were 2 problems with this script:
1) patch doesn't preserve +x,
2) if /etc/webcalendar/settings.php doesn't exist you get a failed upgrade.
Both of these are fixed in -3
How about a little more notice next time you decide to do an NMU?
--
Timothy Peeler <[EMAIL PROTECTED]>
Senior Programmer, Systems Administrator
LinuxForce Inc. (http://www.LinuxForce.net)
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
