Source: mojoshader
Version: 0.0~hg1314+dfsg-1
Severity: minor

The patches in debian/patches/*.patch do not contain information about
why it was necessary to patch the upstream source code, or whether the
change has been applied upstream, rejected upstream, or sent to upstream,
or is Debian-specific and not intended for upstream.

This sort of information is very valuable when you come back to a package
after several months or years and want to know why a former maintainer
(perhaps you!) made a particular change.

debian/patches/CMakeLists.patch seems to contain multiple unrelated changes,
so it would be useful to break it up into changes that are individually
correct and useful - particularly if some of those changes are suitable
for upstream and some are Debian-specific.

I would recommend using <https://dep-team.pages.debian.net/deps/dep3/>.
The dialect of DEP-3 that looks like `git format-patch` output is often
easiest to work with, particularly if you are using git-buildpackage and
related tools. For example, the patches I sent to
https://salsa.debian.org/yangfl-guest/mojoshader/-/merge_requests/1
and https://salsa.debian.org/yangfl-guest/mojoshader/-/merge_requests/2
have this information.

    smcv

Reply via email to