X-Debbugs-CC: allan grossman <wizard10...@gmail.com>

After looking at the code I'm fairly certain the segfault happens in
Controller::handleReplyCheckUpdates() in src/core/controller.cpp which
gets passed to the connect() call.  The culprit is probably line 195:

            m_appUpdates->setText(newVersion);

Since I cannot reproduce it I can't look at it in a debugger.  Allan,
if you want you can try running this in gdb like so:

    gdb flameshot

and then in gdb

    start
    continue
    backtrace 5

and give us the output.  I speculate for people with very fast
Internet connections the call to setText() happens before m_appUpdates
gets initialized, maybe because the compiler reorders statements.

A fix could consist of one of these changes:

 * Return immediately from
   src/core/controller.cpp:Controller::getLatestAvailableVersion() to
   disable update checks altogether.

 * Initialize res with false instead of true in
   src/utils/confighandler.cpp:ConfigHandler::checkForUpdates()
   to turn off update checks by default.

Regards.

Reply via email to