Hi - as an FYI on s390x tests
https://ci.debian.net/data/autopkgtest/unstable/s390x/p/pyspread/13200913/log.gz
there are further test issues of the new tests added in 1.99.6

I've reported them upstream at
https://gitlab.com/pyspread/pyspread/-/issues/93

To fix the test is easy (just drop the special case for not little
endian), but while I'm 95% sure that is fine I'm lacking the final 5%
and would want to have upstreams answers to it before suggesting to
change this in freeze time.

P.S. I'm unsure if a second forwarded tag might cause problems and
this issue is related but not necessarily considered the very same, so
I'm intentionally NOT adding a new forwarded tag.

Test fail log:

__________________________________ test_RGB32 __________________________________

    def test_RGB32():
        qimg = QtGui.QImage(320, 240, QtGui.QImage.Format_RGB32)
        qimg.fill(0)
        v = _qimageview(qimg)
        qimg.fill(23)
        qimg.setPixel(12, 10, QtGui.qRgb(0x12, 0x34, 0x56))
        assert_equal(v.shape, (240, 320))
        assert_equal(v[10, 10], 23 | 0xff000000)
>       assert_equal(v[10, 12], 0xff123456
                     if sys.byteorder == 'little' else 0x563412ff)

pyspread/lib/test/test_qimageview.py:145:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

a = 4279383126, b = 1446253311

    def assert_equal(a, b):
>       assert a == b
E       assert 4279383126 == 1446253311

pyspread/lib/test/test_qimageview.py:72: AssertionError
_________________________________ test_ARGB32 __________________________________

    def test_ARGB32():
        qimg = QtGui.QImage(320, 240, QtGui.QImage.Format_ARGB32)
        qimg.fill(0)
        v = _qimageview(qimg)
        qimg.setPixel(12, 10, QtGui.qRgb(0x12, 0x34, 0x56))
        assert_equal(v.shape, (240, 320))
>       assert_equal(v[10, 12], 0xff123456
                     if sys.byteorder == 'little' else 0x563412ff)

pyspread/lib/test/test_qimageview.py:156:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

a = 4279383126, b = 1446253311

    def assert_equal(a, b):
>       assert a == b
E       assert 4279383126 == 1446253311



-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

Reply via email to