On 2021/08/26 04:25 PM, Mattia Rizzolo wrote: > > What would you say about this patch: > > |--- a/README.rst > |+++ b/README.rst > |@@ -378,9 +378,9 @@ mechanism to vary the system time. > | Kernel > | ------ > | > |-The "kernel" variation is currently not working for RPM based packages. > While > |-building with this variation enabled, the tool > `/usr/lib/rpm/redhat/brp-ldconfig` > |-compains about `FATAL: kernel too old` and aborts the build. > |+The "kernel" variation is currently not working for RPM based packages and > other > |+build process requiring `ldconfig`. While building with this variation > enabled, > |+`ldconfig` complains about `FATAL: kernel too old` and aborts the build. > | > | Avoid sudo(1) password prompts > | ==============================
Looks good to me. > Besides potentially better identifying which versions of ldconfig are > effectively broken, I don't think we could do much else. IIRC, the change was introduced by https://salsa.debian.org/glibc-team/glibc/-/commit/2d7aa68d5d30a203b61b551432efcefac7413885#98f7bc9994884d56cdc1b30b364e50f8800dbc07_147_147 which was packaged with glibc-2.25. I agree. A possibility would be to introduce a '--uname-3.2' to setarch and I don't think, for the number of packages using ldconfig at build time, this is worth the trouble (specially since upstream might not be interested by it). -- Baptiste Beauplat - lyknode
signature.asc
Description: PGP signature
