Hi sorry for being slow about looking at this.

This is the ultimate answer after updating the package and looking to
see where the config block is generated I found this text.

   *Note: for historical reasons we also look in the ``~/.dask``
   directory for config files.  This is deprecated and will soon be
   removed.*
   
I think upstream just removed the block that was causing the
unreproducible change you spotted.

I started thinking that the patch probably wouldn't work correctly
because python IO functions won't internally expand "~" when trying to
open files. So, depending on how widely dask.config.paths is used in
dask,  that might cause problems when opening files.

Thanks you for encouraging me to make better packages.

Diane

On Fri, 2021-07-09 at 07:08 -0700, Vagrant Cascadian wrote:
> Package: dask
> Severity: normal
> Tags: patch
> User: reproducible-bui...@lists.alioth.debian.org
> Usertags: environment
> X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
> 
> The home directory is embedded in html documentation:
> 
>  
> https://tests.reproducible-builds.org/debian/rb-pkg/bullseye/amd64/diffoscope-results/dask.html
> 
>   /usr/share/doc/python-dask-doc/html/configuration.html
> 
>   ...
> <span·class="default_value">['/etc/dask',·'/usr/etc/dask',·'/nonexist
> ent/first-build/.config/dask',·'/nonexistent/first-
> build/.dask']</span> ...
> vs.
>   ...
> <span·class="default_value">['/etc/dask',·'/usr/etc/dask',·'/nonexist
> ent/second-build/.config/dask',·'/nonexistent/second-
> build/.dask']</span> ...
> 
> 
> The attached patch fixes this by modifying dask/config.py to not
> expand
> the tilde to the user home dir.
> 
> While the patch does make the documentation reproducible, it needs
> some
> run-time testing to ensure that dask works correctly with the patch
> applied (e.g. the configuration is checked for in the user's
> ~/.config/dask and ~/.dask directories)! Someone familiar with dask
> should test this before applying the patch!
> 
> If it causes issues, taking a deeper look into fixing this in the
> documentation will be needed.
> 
> 
> With this patch applied, dask should become reproducible in the
> tests.reproducible-builds.org infrastructure.
> 
> 
> Thanks for maintaining dask!
> 
> 
> live well,
>   vagrant

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to