Package: ifupdown-extra
Version: 0.32
Severity: important
Tags: patch

Dear Maintainer,

/usr/sbin/arping from `arping` package uses '-d' option to detect duplicates, 
not '-D'. I fixed it in the provided patch (also took the liberty to fix the 
case for the interface flag).

Also, the default ARP_TIMEOUT set in /etc/default/network-test renders 
ineffective the specific setting of 1500 ms for it in the script, which should 
be at least noted in the comments or README.

-- System Information:
Debian Release: 11.0
  APT prefers stable
  APT policy: (991, 'stable'), (500, 'stable-security'), (500, 'oldstable'), 
(99, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.10.46-bootes0-p-1000 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
LSM: AppArmor: enabled

Versions of packages ifupdown-extra depends on:
ii  arping               2.21-2
ii  bind9-host [host]    1:9.16.15-1
ii  curl                 7.74.0-1.3+b1
ii  dpkg                 1.20.9
ii  iproute2             5.10.0-4
ii  iputils-ping [ping]  3:20210202-1
ii  lsb-base             11.1.0
ii  net-tools            1.60+git20181103.0eebece-1
ii  netcat-openbsd       1.217-3

Versions of packages ifupdown-extra recommends:
ii  ethtool  1:5.9-1
ii  ndisc6   1.0.4-2

ifupdown-extra suggests no packages.

-- Configuration Files:
/etc/default/network-test changed [not included]
/etc/network/if-up.d/10check-duplicate-ip changed [not included]

-- no debconf information
--- 10check-duplicate-ip.org	2021-09-07 09:22:25.000000000 +0500
+++ 10check-duplicate-ip	2021-09-07 10:22:16.000000000 +0500
@@ -83,7 +83,7 @@
         # Skip interface is address is IPv6, arping only works for IPv4
             if ! echo ${ADDR} | grep -q ":" ; then
 		[ "$VERBOSITY" -eq 1 ] && $OUTPUT "DEBUG: Sending arp pings through $real_iface (for $IFACE) to detect other systems using $ADDR"
-                $ARPING -c $ARP_COUNT -w $ARP_TIMEOUT -D -I $real_iface $ADDR $ARPING_EXTRAOPTS >$ARPING_REDIR
+                $ARPING -c $ARP_COUNT -w $ARP_TIMEOUT $ARPING_DAD $ARPING_IFACE $real_iface $ADDR $ARPING_EXTRAOPTS >$ARPING_REDIR
 		if [ $? -ne 0 ] ; then
                     $OUTPUT "ERROR: Duplicate address $ADDR assigned in the network where $real_iface is connected to."
 		fi
@@ -119,6 +119,8 @@
     ARPING=/usr/bin/arping
     ARP_TIMEOUT=${ARP_TIMEOUT:-3} # Time here is measured in seconds
     ARPING_EXTRAOPTS="-q"         # Use -q(uiet) in iputil's arping
+    ARPING_DAD="-D"               # Detect duplicates
+    ARPING_IFACE="-I"             # Interface
     ARPING_REDIR="/dev/stdout"    # Do not redirect output
 else
     if [ -x /usr/sbin/arping ] ; then
@@ -126,6 +128,8 @@
         ARP_TIMEOUT=${ARP_TIMEOUT:-1500} # Time here is measures in milliseconds
                                          # experiments show anything less than 1500 is unreliable.
         ARPING_EXTRAOPTS=""              # No '-q' option in arping
+        ARPING_DAD="-d"                  # Detect duplicates
+        ARPING_IFACE="-i"                # Interface
         ARPING_REDIR="/dev/null"        # Send output to /dev/null if using this program
     else
         # Do not continue if ARPING is not available

Reply via email to