Hi Chris,

On Sun, Sep 12, 2021 at 3:33 AM Christoph Anton Mitterer
<cales...@scientia.net> wrote:
>
> Hey.
>
> https://s2geometry.io/ indeed also mentiones a Java port, but the one
> at https://github.com/google/s2-geometry-library-java and not what you
> said you'd have used
> (https://github.com/io-sgr/s2-geometry-library-java ?)

I had been thinking about this one and I think I should not have used
that link as the homepage.

>
> But even the "official" Google port to Java is listed only as "Ported
> Subset".
>
>
> With Emmanuel doing the C++/Python reference implementation in #962686,
> may I suggest the following:
>
> Neither of the two packages uses https://s2geometry.io/ as homepage
> field, but the github address of the project.
>
> https://s2geometry.io/ seems to be anyway rather a "general" page about
> the S2 system, less about specific implementations.

Yes, and what about mentioning in the package description:
"Additional documents can be found at https://s2geometry.io/";

>
>
> Cheers,
> Chris.
>
> PS: Wouldn't it make sense for s2-geometry-library to switch to the
> google port https://github.com/google/s2-geometry-library-java and
> perhaps also name the sourcepackage accordingly (s2-geometry-library-
> java)?
> The google one seems to still get commits, the other one hasn't seen
> commits since 2019.

Google one got its commit after 10 years :)
Anyways, s2-geometry-library is a dependency of lucene8. I can check
if it can use the google version. But iirc, upstream lucene8 was using
the non-google port.


-- 
Regards
Sudip

Reply via email to