Bug#984353: surf-alggeo: ftbfs with GCC-11

[Torrance, Douglas]

Control: tags -1 patch

On Wed, 03 Mar 2021 16:17:45 +0000 Matthias Klose <d...@debian.org> wrote:
> ../../../yaccsrc/Script.cc: In static member function ‘static void 
> Script::clearScreen()’:
> ../../../yaccsrc/Script.cc:910:23: error: reference to ‘byte’ is ambiguous
>   910 |         *intensity = (byte)(-print_background_data);
>       |                       ^~~~
> In file included from /usr/include/c++/11/bits/stl_algobase.h:61,
>                  from /usr/include/c++/11/bits/char_traits.h:39,

This is due to the introduction of std::byte in C++17, which is default in GCC 
11.  One band-aid fix would be to explicitly drop back to C++14 -- see the 
attached patch.

In the long term, it would probably be good to drop all the various instances 
of "using namespace std".

Doug
From 1c7279785ea154905b33cdcafe79087efff39f44 Mon Sep 17 00:00:00 2001
From: Doug Torrance <dtorra...@piedmont.edu>
Date: Mon, 11 Oct 2021 16:09:53 -0400
Subject: [PATCH] Compile with C++14 standard to avoid byte v. std::byte
 issues.

---
 debian/rules | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/rules b/debian/rules
index 3018e1a..e9aa70a 100755
--- a/debian/rules
+++ b/debian/rules
@@ -2,6 +2,7 @@
 include /usr/share/dpkg/pkg-info.mk
 
 export DEB_BUILD_MAINT_OPTIONS=hardening=+all
+export DEB_CPPFLAGS_MAINT_APPEND = -std=gnu++14
 
 DEB_VIRT_SURFALGGEO_LISTOF_VARIANT = nox ##gtk
 
-- 
2.30.2