Hi,

On 20/10/2021 15:29, Jesse Smith wrote:
Is there a reason for wanting to revert this behaviour instead of using
the "-z" flag on the command line? If you use pidof a lot and expect to
see processes that are in the uninterruptable sleep state then making an
alias of pidof='pidof -z' seems like a straight forward approach.

Reverting the change entirely means the default behaviour could hang in
NFS environments and I'm not sure non-functioning is a better situation
than skipping sleeping processes.

The RedHat bug that was the similar issue to #719273 (i.e. that resulted in the behaviour of pidof being changed) took a slightly different approach - https://bugzilla.redhat.com/show_bug.cgi?id=138788 (patch is https://bugzilla.redhat.com/attachment.cgi?id=113650&action=diff ); did that ever make its way to upstream?

My feeling is that I'd like us to follow upstream's approach here (hi Jesse :) ); it's not obvious to me that having "do look at D processes" be an optional switch is wrong.

Regards,

Matthew

Reply via email to