On Oct 26, Lukas Märdian <sl...@ubuntu.com> wrote:

> In Ubuntu, the attached patch was applied to achieve the following:
I will be happy to merge something which can achieve this, but I need 
a few clarifications first.

> +     if (-e "/usr$n" && $n ~~ @generated_files) {
Is it really needed to check this before the following file != directory 
checks?
This looks like a bug, because rm would fail if $n were a directory.
> +             rm('-f', "$n");
Does -f actually have a purpose here?
> +             return;
> +     }
> +
>       fatal("$n is a directory and /usr$n is not")
>               if -d $n and -e "/usr$n";
>       fatal("/usr$n is a directory and $n is not")

-- 
ciao,
Marco

Attachment: signature.asc
Description: PGP signature

Reply via email to