Package: python-pika-pool
Version: 0.1.3-4
Severity: important

Hello,

We are currently working towards getting python-pika updated to its
latest version, 1.2.0.  This is needed for the latest version of pagure
(https://pagure.io).  There's an ongoing discussion here, if you're
interested:

  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=900808

python-pika 1.2.0 breaks its API, but we have built and tested most of
its reverse-dependencies and verified that they seem to work fine with
the latest version.  The only problematic rdep is python-pika-pool.

The package builds fine with python-pika 1.2.0, but its autopkgtest
fails with:

--8<---------------cut here---------------start------------->8---
autopkgtest [20:06:52]: test python3-unit-tests: [-----------------------
============================= test session starts ==============================
platform linux -- Python 3.9.8, pytest-6.2.5, py-1.10.0, pluggy-0.13.0
rootdir: /tmp/autopkgtest.WYlkRs/build.4fv/src
collected 9 items

test.py EEEEEEEEE                                                        [100%]

==================================== ERRORS ====================================
___________________ ERROR at setup of TestNullPool.test_pub ____________________

params = <URLParameters host=localhost port=5672 virtual_host=/ ssl=False>

    @pytest.fixture(scope='session', autouse=True)
    def consume(params):
    
        def _callback(ch, method, properties, body):
            msg = Message.from_json(body)
            consumed[msg.id] = msg
    
        def _forever():
            channel.start_consuming()
    
        cxn = pika.BlockingConnection(params)
        channel = cxn.channel()
        channel.queue_declare(queue='pika_pool_test')
>       channel.basic_consume(_callback, queue='pika_pool_test', no_ack=True)
E       TypeError: basic_consume() got multiple values for argument 'queue'

test.py:44: TypeError
________________________ ERROR at setup of test_use_it _________________________

params = <URLParameters host=localhost port=5672 virtual_host=/ ssl=False>

    @pytest.fixture(scope='session', autouse=True)
    def consume(params):
    
        def _callback(ch, method, properties, body):
            msg = Message.from_json(body)
            consumed[msg.id] = msg
    
        def _forever():
            channel.start_consuming()
    
        cxn = pika.BlockingConnection(params)
        channel = cxn.channel()
        channel.queue_declare(queue='pika_pool_test')
>       channel.basic_consume(_callback, queue='pika_pool_test', no_ack=True)
E       TypeError: basic_consume() got multiple values for argument 'queue'

test.py:44: TypeError
_________ ERROR at setup of TestQueuedPool.test_invalidate_connection __________

params = <URLParameters host=localhost port=5672 virtual_host=/ ssl=False>

    @pytest.fixture(scope='session', autouse=True)
    def consume(params):
    
        def _callback(ch, method, properties, body):
            msg = Message.from_json(body)
            consumed[msg.id] = msg
    
        def _forever():
            channel.start_consuming()
    
        cxn = pika.BlockingConnection(params)
        channel = cxn.channel()
        channel.queue_declare(queue='pika_pool_test')
>       channel.basic_consume(_callback, queue='pika_pool_test', no_ack=True)
E       TypeError: basic_consume() got multiple values for argument 'queue'

test.py:44: TypeError
__________________ ERROR at setup of TestQueuedPool.test_pub ___________________

params = <URLParameters host=localhost port=5672 virtual_host=/ ssl=False>

    @pytest.fixture(scope='session', autouse=True)
    def consume(params):
    
        def _callback(ch, method, properties, body):
            msg = Message.from_json(body)
            consumed[msg.id] = msg
    
        def _forever():
            channel.start_consuming()
    
        cxn = pika.BlockingConnection(params)
        channel = cxn.channel()
        channel.queue_declare(queue='pika_pool_test')
>       channel.basic_consume(_callback, queue='pika_pool_test', no_ack=True)
E       TypeError: basic_consume() got multiple values for argument 'queue'

test.py:44: TypeError
_________________ ERROR at setup of TestQueuedPool.test_expire _________________

params = <URLParameters host=localhost port=5672 virtual_host=/ ssl=False>

    @pytest.fixture(scope='session', autouse=True)
    def consume(params):
    
        def _callback(ch, method, properties, body):
            msg = Message.from_json(body)
            consumed[msg.id] = msg
    
        def _forever():
            channel.start_consuming()
    
        cxn = pika.BlockingConnection(params)
        channel = cxn.channel()
        channel.queue_declare(queue='pika_pool_test')
>       channel.basic_consume(_callback, queue='pika_pool_test', no_ack=True)
E       TypeError: basic_consume() got multiple values for argument 'queue'

test.py:44: TypeError
_________________ ERROR at setup of TestQueuedPool.test_stale __________________

params = <URLParameters host=localhost port=5672 virtual_host=/ ssl=False>

    @pytest.fixture(scope='session', autouse=True)
    def consume(params):
    
        def _callback(ch, method, properties, body):
            msg = Message.from_json(body)
            consumed[msg.id] = msg
    
        def _forever():
            channel.start_consuming()
    
        cxn = pika.BlockingConnection(params)
        channel = cxn.channel()
        channel.queue_declare(queue='pika_pool_test')
>       channel.basic_consume(_callback, queue='pika_pool_test', no_ack=True)
E       TypeError: basic_consume() got multiple values for argument 'queue'

test.py:44: TypeError
________________ ERROR at setup of TestQueuedPool.test_overflow ________________

params = <URLParameters host=localhost port=5672 virtual_host=/ ssl=False>

    @pytest.fixture(scope='session', autouse=True)
    def consume(params):
    
        def _callback(ch, method, properties, body):
            msg = Message.from_json(body)
            consumed[msg.id] = msg
    
        def _forever():
            channel.start_consuming()
    
        cxn = pika.BlockingConnection(params)
        channel = cxn.channel()
        channel.queue_declare(queue='pika_pool_test')
>       channel.basic_consume(_callback, queue='pika_pool_test', no_ack=True)
E       TypeError: basic_consume() got multiple values for argument 'queue'

test.py:44: TypeError
________________ ERROR at setup of TestQueuedPool.test_timeout _________________

params = <URLParameters host=localhost port=5672 virtual_host=/ ssl=False>

    @pytest.fixture(scope='session', autouse=True)
    def consume(params):
    
        def _callback(ch, method, properties, body):
            msg = Message.from_json(body)
            consumed[msg.id] = msg
    
        def _forever():
            channel.start_consuming()
    
        cxn = pika.BlockingConnection(params)
        channel = cxn.channel()
        channel.queue_declare(queue='pika_pool_test')
>       channel.basic_consume(_callback, queue='pika_pool_test', no_ack=True)
E       TypeError: basic_consume() got multiple values for argument 'queue'

test.py:44: TypeError
____________ ERROR at setup of TestQueuedPool.test_timeout_override ____________

params = <URLParameters host=localhost port=5672 virtual_host=/ ssl=False>

    @pytest.fixture(scope='session', autouse=True)
    def consume(params):
    
        def _callback(ch, method, properties, body):
            msg = Message.from_json(body)
            consumed[msg.id] = msg
    
        def _forever():
            channel.start_consuming()
    
        cxn = pika.BlockingConnection(params)
        channel = cxn.channel()
        channel.queue_declare(queue='pika_pool_test')
>       channel.basic_consume(_callback, queue='pika_pool_test', no_ack=True)
E       TypeError: basic_consume() got multiple values for argument 'queue'

test.py:44: TypeError
=========================== short test summary info ============================
ERROR test.py::TestNullPool::test_pub - TypeError: basic_consume() got multip...
ERROR test.py::test_use_it - TypeError: basic_consume() got multiple values f...
ERROR test.py::TestQueuedPool::test_invalidate_connection - TypeError: basic_...
ERROR test.py::TestQueuedPool::test_pub - TypeError: basic_consume() got mult...
ERROR test.py::TestQueuedPool::test_expire - TypeError: basic_consume() got m...
ERROR test.py::TestQueuedPool::test_stale - TypeError: basic_consume() got mu...
ERROR test.py::TestQueuedPool::test_overflow - TypeError: basic_consume() got...
ERROR test.py::TestQueuedPool::test_timeout - TypeError: basic_consume() got ...
ERROR test.py::TestQueuedPool::test_timeout_override - TypeError: basic_consu...
============================== 9 errors in 0.06s ===============================
autopkgtest [20:06:53]: test python3-unit-tests: -----------------------]
autopkgtest [20:06:54]: test python3-unit-tests:  - - - - - - - - - - results - 
- - - - - - - - -
python3-unit-tests   FAIL non-zero exit status 1
--8<---------------cut here---------------end--------------->8---


As far as we have checked:

1) python-pika-pool doesn't have an active upstream.  The last commit
  was made in 2016, there are some issues opened requesting a new
  release, and also some pull-requests waiting for review.

2) python-pika-pool doesn't have any reverse-dependencies itself.

3) Even if the error can be fixed (and it looks like this would involve
   patching the testsuite), we still cannot guarantee there the package
   will perform correctly with the new python-pika.

Having said all that, I am inclined to request the removal of the
package from the archives in order to facilitate the transition of
python-pika.

Please, let me know what you think and if there are any concerns that
I'm not envisioning here.

Thank you,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
https://sergiodj.net/

Attachment: signature.asc
Description: PGP signature

Reply via email to