Control: tags -1 moreinfo
Am 17.11.21 um 14:57 schrieb Lance Lin:
I've uploaded a new version of workflow with the suggested changes.
The filenamemangle in the debian/watch file is not correct. Please test it
with uscan.
Unfortunately I am not able to reproduce any errors with the watch file. uscan
also does not return any errors. Is there something specific I should look at?
No, it is okay now. Maybe GitHub has had some changes on their releases/tags
site again. Or I was mistaken.
There are missing copyright notices and BSD licenses in src/util/crc32c.*
I reviewed the files and crc32c.h has the "BSD 2-Point" license text without
explicitly calling it as such. crc32c.c has a copyright notice and free distribution
notice but it is non-traditional and added by the original author, Mark Adler. Is this
sufficient?
crc32c.c is licensed under the zlib license. I do not know what you mean by
"non-traditional".
You have not changed the d/copyright accordingly. While the zlib license is not required to be included legally in
d/copyright (source requirements are fulfilled; no binary requirements), Debian Policy requires it.
The BSD-2-clause and the Magnus Edenhill copyright notice have to be included
legally and by Debian Policy.
