Hi Glenn! On 1/3/22 03:21, Glenn Washburn wrote: > Creating an HFS volume with a volume name other than the default of > "untitled" is currently not possible. It does appear that it should be > possible. Here is output exhibiting this issue: > (...) > Looking at the package source, I see that HFS volume creation is added > as a debian package patch and not part of the upstream source in patch > file > debian/patches/0005-Re-add-support-for-creating-legacy-HFS-filesystems.patch.
Yes, this patch was created by me since we need legacy HFS support for the Apple PowerMacs that we support in Debian Ports for the powerpc and ppc64 ports. > The issue appears to be that the volume name passed in as the -v option > argument and being written to the hfs parameters struct is being > unconditionally overritten in line 325 of the patch file with the > default volume name. This can be fixed by swapping the first two > aruments to bcopy on that line, however, the comment and the lines > directly above it lead me to believe there's potentially more to it. > > This is causing GRUB HFS tests to fail and it would be nice to get them > passing again without disabling the failing test. Thanks for debugging and reporting this. I will have a look at this bug and fix it hopefully soon. Also, thanks for fixing so many issues in GRUB, I'm on the GRUB mailing list as well and I'm seeing your regular influx of patches there! Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
