Hi,

On Fri, Jun 18, 2021 at 02:30:03PM +1000, Jai Flack wrote:
On Sun, 21 Feb 2021 17:11:28 +0100 Jonas Smedegaard <d...@jones.dk> wrote:
Debian Policy §12.6 says that /usr/share/doc/*/examples/ is "for the
benefit of the system administrator and users as documentation only."

Notice the final part of "documentation only".

That is a good point; as they are intended for use I'll move them out of
doc/. This is also good opportinity to install the bash completions by
default and maybe the Vim plugin if it's not too intrusive.

It's worth noting that completion of command-line arguments of fzf itself is only a secondary purpose of /usr/share/bash-completion/completions/fzf, the primary purpose being augmenting completion of other commands to use fzf, as described here: https://github.com/junegunn/fzf#fuzzy-completion-for-bash-and-zsh

This primary purpose, however, isn't active via the bash-completion autoloading. As things currently stand, it only becomes active after one types fzf a presses Tab, which is probably not a good experience. So I believe the note in /usr/share/doc/fzf/README.Debian about the completion being installed by default is incorrect, and should be reverted and the path corrected to /usr/share/bash-completion/completions/fzf (rather than /usr/share/doc/fzf/examples/completion.bash, which is still in README.Debian).

Alternatively, the file can be installed into /etc/bash_completion.d, which is the compat (no autoload) dir for old-style bash-completion modules, so it will indeed get loaded unconditionally. I'd personally prefer the former solution, though.

--
Tomáš "liskin" ("Pivník") Janoušek, https://lisk.in/

Reply via email to